Comments (3)
I did initial investigation regarding passing a cancelable context to BeginRunCommand
and it seems it doesn't help with cancelling the actual run command and only effects the polling:
Error: failed to run command: error polling command response: context deadline exceeded
I will investigate if there is still an option to avoid conflicts when re-running the command.
from kubectl-aks.
I just realize that maybe we won't be able to do too much on this issue after re-reading the documentation:
You can't cancel a running script.
Maybe, what we can do is to handle this kind of signals and improve the UX:
$ kubectl az run-command "ip route" --node aks-agentpool-12345678-vmss000000
Running...
^C
Warn: The requested command hasn't finished yet...
Warn: Hit Ctrl+C again to exit, but please notice the command will continue running in the node anyway, and you will be unable to see the output or run another command until it finishes.
^C
Exiting...
$
from kubectl-aks.
I agree. I think having a warning like this can be useful so users are aware of the consequence of cancellation an unfinished command. Also, I am thinking of wrapping the run-command in timeout and set the default value to 300
seconds . Let me have a look into this.
from kubectl-aks.
Related Issues (20)
- [RFE] Allow setting resource parameters for the next operations
- [RFE] Generate krew update PR from CI release job
- [RFE] Add golang linter in CI HOT 1
- [RFE] Improve run-command's output formatting HOT 6
- [RFE] Implement `ssh` command HOT 1
- [RFE] Support interactive mode in `run-command`
- [RFE] Integrate `ig` as subcommand HOT 1
- [RFE] Request `kubectl-az` to be added to `krew`
- [RFE] Add CI documentation
- Rename plugin to `kubectl-aks`
- [RFE] ci: Avoid running workflow when not needed HOT 2
- `run-command` reports the *last* 4096 bytes of the output
- [RFE] Support importing configuration regardless the status of the k8s control plan
- Allow setting a default subscription as `az` does
- Add flag `--current-node` to `set-node` command
- Allow running `check-apiserver-connectivity` on multiple nodes in parallel
- Verbose flag should set the logrus log level HOT 1
- Print imported information after running `config import`
- ci: Use an official released version of `ie`
- [RFE] Implement `cp` command HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubectl-aks.