Giter Club home page Giter Club logo

Comments (3)

mqasimsarfraz avatar mqasimsarfraz commented on August 26, 2024 1

I did initial investigation regarding passing a cancelable context to BeginRunCommand and it seems it doesn't help with cancelling the actual run command and only effects the polling:

Error: failed to run command: error polling command response: context deadline exceeded

I will investigate if there is still an option to avoid conflicts when re-running the command.

from kubectl-aks.

blanquicet avatar blanquicet commented on August 26, 2024 1

I just realize that maybe we won't be able to do too much on this issue after re-reading the documentation:

You can't cancel a running script.

Maybe, what we can do is to handle this kind of signals and improve the UX:

$ kubectl az run-command "ip route" --node aks-agentpool-12345678-vmss000000
Running...
^C
Warn: The requested command hasn't finished yet...
Warn: Hit Ctrl+C again to exit, but please notice the command will continue running in the node anyway, and you will be unable to see the output or run another command until it finishes.
^C
Exiting...
$ 

from kubectl-aks.

mqasimsarfraz avatar mqasimsarfraz commented on August 26, 2024

I agree. I think having a warning like this can be useful so users are aware of the consequence of cancellation an unfinished command. Also, I am thinking of wrapping the run-command in timeout and set the default value to 300 seconds . Let me have a look into this.

from kubectl-aks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.