Comments (5)
@live1206: This is related to the LRO rehydration changes. Please take a look at ways we can make this AOT compatible, given that we can't know what libraries are using them.
//cc: @ArthurMa1978, @m-nash
from azure-sdk-for-net.
I hadn't considered that new changes in Azure.Core could break us.
Yes! Anything changing in your dependencies might break/affect your code. A lower level API could decide to do something incompatible and add a [RequiresUnreferencedCode]
attribute to a method you call, and now you have warnings.
So it would be good to get CI checks to ensure libraries that should be AOT compatible, stay AOT compatible.
from azure-sdk-for-net.
Sorry for the delay - was OOF. The AOT CI was passing for this particular PR, I will follow up on why it didn't catch this regression. I'm assuming it's because our pipelines are still running .NET 7 which is a known limitation of the CI.
And @TimothyMothra I'll respond to your email today about onboarding exporter (although like you mentioned, this wouldn't have prevented this).
from azure-sdk-for-net.
do you know why these warnings aren't being caught by https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/test-aot-compat.ps1?
Hello, that test app isn't connected to any CI. I added that to manually verify we were AOT compliant for the NET8 release.
@m-redding added a CI pipeline in Dec #40629 and it's on my backlog to onboard to this. This was a lower priority because development has slowed on the Exporter. I hadn't considered that new changes in Azure.Core could break us.
from azure-sdk-for-net.
I'm having some issues onboarding to the AOT CI. I'll need to follow up with @m-redding when she's available.
Some other questions/concerns came up while onboarding.
- Onboarding our
Exporter
to the AOT CI will only run in themonitor
subdirectory. This would catch regressions in my library before releasing, but this wouldn't have caught changes as they occur in theAzure.Core
library. Azure.Core
is already onboarded to the AOT CI (link) and it didn't catch this regression.
from azure-sdk-for-net.
Related Issues (20)
- [FEATURE REQ] Azure.AI.OpenAI: Support HuggingFace chat completion streaming API HOT 1
- Re-record Compute tests
- [Storage] Mismatch in docs and code behaviour HOT 3
- [FEATURE REQ] Add keys operation to Azure.ResourceManager.KeyVault HOT 2
- [BUG] ArmAppServiceModelFactory is not contained in the Azure.ResourceManager.AppService nuget package HOT 4
- [BUG] Fails to find existing Host resource in a Resource Group HOT 3
- Update Embedding Type to Support Narrow Data Types HOT 1
- [BUG] Activity.Tags not exported to customDimensions HOT 6
- [FEATURE REQ] Remove package reference workaround after Azure.Core new release
- Create an interface `IJsonModel` in `System.ClientModel` library
- [FEATURE REQ] Get rid of hardcoded OpenAI-endpoint in OpenAIClient HOT 3
- [BUG]Azure OpenAI library is failed in MAUI HOT 6
- [BUG] Azure.AI.OpenAI.Assistants - I'm not able to ask question about the content of a file uploaded in the Storage HOT 2
- [BUG] Azure Function with Event Hub trigger and `EventData` as argument, fails with serialization error HOT 1
- [BUG] Not overwrite in updateasync HOT 1
- Units not specified for buffer size HOT 1
- [BUG] Equality failures due to implicit cast on RequestFailedException.ErrorCode HOT 1
- Azure Maps SDK for Unity? HOT 1
- Documentation should mention about the parameter value in GetPageRangesDiffOptions HOT 1
- [BUG] Error while trying to access keys stored in Azure KeyVault HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-sdk-for-net.