[QUERY] - Register custom HttpClient about azure-sdk-for-net HOT 2 OPEN

Hi @schmallaria. Thanks for reaching out and for your inquiry. While you could create a client factory that would allow you to register an HttpClient via the AddAzureClients extension, there's no benefit over using the standard DI registration path, as it will not achieve your goal.

The Azure clients use a well-known pattern for authentication via Azure.Identity credentials and Azure.Core's configuration options which the AddAzureClients uses to configure and inject credentials. The HttpClient type does not support those constructs nor the Azure SDK patterns. You would be better off configuring/registering your HttpClient with the standard DI path and injecting a TokenCredential into wherever you're using HttpClient and then manually requesting the token from it.

Something like:

// Assumption "MyClass" is created by DI, which injects the registered client and credential.
public class MyClass
{
    private HttpClient _httpClient;
    priivate TokenCredential _credential;

    public MyClass(HttpClient httpClient, TokenCredential credential) => (_ httpClient, _credential) = (httpClient, credential)

    public async Task DoTheThing()
    {
        var bearerToken = await _credential.GetTokenAsync(
            new TokenRequestContext(new[] { "http://some.service.com/.default" }), CancellationToken.None);    
    
        var message = new HttpRequestMessage(HttpMethod.Get, new Uri("https://www.google.com"));
        message.Headers.Authorization = new AuthenticationHeaderValue("Bearer", bearerToken.Token);
    
        await _httpClient.SendAsync(message);
    }
}

from azure-sdk-for-net.

Hi @schmallaria. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

from azure-sdk-for-net.