Giter Club home page Giter Club logo

Comments (5)

zikalino avatar zikalino commented on August 20, 2024

this issue should be fixed now.

from ansible-playbooks.

yungezz avatar yungezz commented on August 20, 2024

@zikalino what does 'should be fixed now' mean? Code fixed in role side? pls run this playbook against latest role and ansible bits, then close the issue if succeeded.

from ansible-playbooks.

yaweiw avatar yaweiw commented on August 20, 2024

if it's verified then just go ahead close the issue.

from ansible-playbooks.

zikalino avatar zikalino commented on August 20, 2024

@yaweiw @yungezz i would like to see it verified by ci before i close it.

from ansible-playbooks.

yungezz avatar yungezz commented on August 20, 2024

@zikalino as we offline synced, pls verify this playbook by yourself, then close the issue if it passed.

As mentioned in email, currently CI on this playbook sample repo is only enabled on master branch, weekly run. It's not enabled for PR because:

  1. this repo is sample playbook repo. We're not targeting to test binaries by this repo, but verifying playbooks, and weather they're working with latest ansible binaries and role bits.
  2. it's unnecessary to run CI which covers all playbooks in this repo per PR, because it just sample and time-consuming. If user create/update a playbook, just verify it by themselves, then check in.

from ansible-playbooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.