Comments (2)
I'm not sure what after
and before
are supposed to do, to be honest. Is the idea that
Str\after('hello world', 'w') === 'orld'
Str\after('hello world', 'w', true) === 'world'
Str\after('hello world', 'w', true, 2) === 'rld'
Str\after('hello world', 'w', false, 2) === 'ld'
Str\before('hello world', 'o') === 'hell'
Str\before('hello world', 'o', true) === 'hello'
Str\before('hello world', 'o', true, 2) === 'hello w'
Str\before('hello world', 'o', false, 2) === 'hello '
I understand based on hack that _last
would indicate using the last occurrence of $needle
in $haystack
and _ci
indicates case insensitive, but wasn't sure if I understood how you wanted after/before to work, and whether the offset was used as a length of to offset from $needle
or what.
from psl.
your understanding is correct, but $offset
is not used as a length, but as an $offset
since these functions would use search
, search_last
, search_ci
, and search_last_ci
internally, the $offset
argument should be passed to the search function.
see: after, afterLast, before, and beforeLast at https://github.com/symfony/string/blob/master/AbstractString.php#L130
from psl.
Related Issues (20)
- [Type] introduce new integer/float functions HOT 1
- [Type] add `nonnull` type
- [Type] add `string_range` and `int_range` types.
- Undeprecate `positive_int` HOT 2
- base64 url safe encoding HOT 1
- Return value of `Psl\Str\trim()` must be of the type string, null returned HOT 6
- `CoercionException::withValue()` called but not throwed. Is this dead code? HOT 1
- Improve error messages for shape and vec -like types
- Improve Dict\merge HOT 1
- Make PSL PHPStan compliant
- Add an `option()` type to `Psl\Type` to coerce to a `Psl\Option\Option` HOT 3
- Split this package is multiple sub-packages HOT 2
- [Bug] Vec\range handles ints which don't roundtrip through floats wrong
- intersection + shapes unexpected behaviour (possible bug?) HOT 4
- Type\implements_interface HOT 3
- Corece an `array` out of an `stdClass`? HOT 3
- [RFC] Change `ResultInterface<T>` to `ResultInterface<T, E>` HOT 5
- chore: rename all enum cases to use PascalCase
- Improvement converted json type HOT 5
- Is nonnull helpful in any way? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psl.