Giter Club home page Giter Club logo

Comments (2)

khamer avatar khamer commented on May 22, 2024 1

I'm not sure what after and before are supposed to do, to be honest. Is the idea that

  • Str\after('hello world', 'w') === 'orld'
  • Str\after('hello world', 'w', true) === 'world'
  • Str\after('hello world', 'w', true, 2) === 'rld'
  • Str\after('hello world', 'w', false, 2) === 'ld'
  • Str\before('hello world', 'o') === 'hell'
  • Str\before('hello world', 'o', true) === 'hello'
  • Str\before('hello world', 'o', true, 2) === 'hello w'
  • Str\before('hello world', 'o', false, 2) === 'hello '

I understand based on hack that _last would indicate using the last occurrence of $needle in $haystack and _ci indicates case insensitive, but wasn't sure if I understood how you wanted after/before to work, and whether the offset was used as a length of to offset from $needle or what.

from psl.

azjezz avatar azjezz commented on May 22, 2024

your understanding is correct, but $offset is not used as a length, but as an $offset since these functions would use search, search_last, search_ci, and search_last_ci internally, the $offset argument should be passed to the search function.

see: after, afterLast, before, and beforeLast at https://github.com/symfony/string/blob/master/AbstractString.php#L130

from psl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.