`Psl\Type\non_empty_string()` is not marked as `@psalm-pure`? about psl HOT 4 OPEN

back to vimeo/psalm#4145 😛

the issue here is that we can't declare Type::assert/Type::coerce as "pure", because not all implementations are pure ( for example IterableType::assert iterates over an iterable, which might not be immutable ).

so i suggest you add @psalm-suppress here.

from psl.

Also, i attempted to improve this by having the psalm plugin report the call as pure if the argument is pure/immutable, but that is not possible via the plugin system, and it seems psalm have a special case for internal php functions ( e.g: https://github.com/vimeo/psalm/blob/bd6efd7cf2b7e6fdf01b343be0c5bbb9aacdbbbb/src/Psalm/Internal/Codebase/Functions.php#L499 )

from psl.

Wow that's ugly :D

Guess we'll have to improve upstream before being able to declare it here: still like vimeo/psalm#4145 as an idea, but hard to bring it to life :-\

from psl.

yea, i will trying to play around with psalm to see if i can make it possible to have special "purity checkers" for function/method calls, this will allow to mark things like Type\string()->assert() pure without the need for vimeo/psalm#4145 using the plugin

from psl.