Comments (10)
Suggesting new AGPL for new modules
Il 20/Lug/2016 19:32, ha scritto:
I would avoid to use old style header to licensing files. I think we just
need to add a LICENSE file for root folder, mostly related to src
directory, and dedicated LICENSE files for each module/ in this way we can
differentiate 3rd party /external modules from main projectIl 20/Lug/2016 18:38, "Francesco Borzì" [email protected] ha
scritto:The license of this project should be set to GNU GPL 2.0, as MaNGOS and
TrinityCore were.Also we should restore the credits to MaNGOS and TrinityCore in source
file headers:https://github.com/AzerothCore/azerothcore-wotlk/blob/master/src/server/game/Spells/Spell.cpp#L2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#21, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI-lIDsvSMY73ALb37mK5rb6T3Stw3oks5qXk72gaJpZM4JQ-JT
.
from azerothcore-wotlk.
I was wrong.
It is OK to keep 'GPLv2 or later' and AGPLv3 files in the same project. When they are combined together during the build process, 'GPLv2 or later' files are interpreted as GPLv3 and there is no incompatibility - they don't need to be relicensed. Sorry for the confusion.
from azerothcore-wotlk.
I would avoid to use old style header to licensing files. I think we just
need to add a LICENSE file for root folder, mostly related to src
directory, and dedicated LICENSE files for each module/ in this way we can
differentiate 3rd party /external modules from main project
Il 20/Lug/2016 18:38, "Francesco Borzì" [email protected] ha
scritto:
The license of this project should be set to GNU GPL 2.0, as MaNGOS and
TrinityCore were.Also we should restore the credits to MaNGOS and TrinityCore in source
file headers:https://github.com/AzerothCore/azerothcore-wotlk/blob/master/src/server/game/Spells/Spell.cpp#L2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#21, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAI-lIDsvSMY73ALb37mK5rb6T3Stw3oks5qXk72gaJpZM4JQ-JT
.
from azerothcore-wotlk.
Agree with AGPL
from azerothcore-wotlk.
File licensed as AGPLv3:
https://github.com/AzerothCore/azerothcore-wotlk/blob/master/src/server/scripts/Kalimdor/RazorfenKraul/instance_razorfen_kraul.cpp
File licensed as GPLv2 (not 'GPLv2 or later' as in TrinityCore):
https://github.com/AzerothCore/azerothcore-wotlk/blob/master/src/server/scripts/Kalimdor/zone_thousand_needles.cpp
I believe those files are linked together in one executable, thus counting as "combined work".
AGPLv3 is not compatible with GPLv2 (source).
This could be solved by relicensing 'GPLv2 or later' files to GPLv3.
But GPLv2 files are stripped of "or later" phrase.
from azerothcore-wotlk.
But GPLv2 files are stripped of "or later" phrase.
this was a mistake that we should fix
from azerothcore-wotlk.
from azerothcore-wotlk.
The issue still exists, i.e. one program is built from GPLv2 and AGPLv3 source files. These licenses are not compatible. Now those GPLv2 files can be relicensed to GPLv3 thanks to 'or later' phrase (GPLv3 can be mixed with AGPLv3 so it fixes the problem), but as it stands they are GPLv2.
IANAL so I may be wrong on this.
from azerothcore-wotlk.
@temzky thanks for your feedback, can you please open a PR to fix the issue?
from azerothcore-wotlk.
no worries and thanks for trying to help!
from azerothcore-wotlk.
Related Issues (20)
- [SSC] Priestess Spirit not spawning HOT 1
- [SSC] Coilfang Fathom-Witch not using Shadow Nova HOT 1
- [SSC] Lady Vashj Elementals walk into the center and despawn HOT 1
- [TK] Kaelthas Mindcontrol should equal a threat drop for the affected person HOT 1
- [TK] Alar Phase 2 should trigger SPELL_HEAL not SPELL_CAST_START for 34342 HOT 2
- [TK] Solarian trash not linked properly HOT 1
- Feature: Wotlk Classic like dungeon lockouts
- [Kara] Attumen always selecting Nightmares HP amount on merge HOT 1
- [Kara] Nightbane phase handling HOT 1
- [SSC] Leotheras demon form always runs into melee range after threat change HOT 1
- [TK] Bloodwarder Marshals cast WW twice HOT 1
- [TK] Kaelthas stops mindcontrolling during P5 transition HOT 1
- [PVP] NPCs in alterac valley cannot be healed by players HOT 1
- [TK] Mindcontrolled trash mobs abilities can be spammed without GCD HOT 1
- [Quest] "You Are Rakh'likh, Demon" mob pathing issue
- Feature: Wotlk classic like arena point calculation as option
- [TBC Vendors] Wrong vendor inventories: Not selling "Wicked Arrow" and "Impact Shot" HOT 5
- Warrior T3 Set Bonus: Hit bonus is detrimental
- acore.sh init fails: functions.sh: line 76: dbasm_import: command not found HOT 1
- Problems encountered during compilation. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azerothcore-wotlk.