Giter Club home page Giter Club logo

Comments (4)

ayushsharma82 avatar ayushsharma82 commented on May 26, 2024

Hi Robert,
Typically you would want to use Serial1 or SoftwareSerial for other applications where you need discrete control over which task can print data.

Currently, ElegantOTA doesn't have any compiler definition to turn off serial debug. I do think that critical tasks like device firmware upgrade should never have their debug output turned off.

from elegantota.

ayushsharma82 avatar ayushsharma82 commented on May 26, 2024

If you are GPIO restricted then you can fork the library and remove all the serial.print lines: https://github.com/ayushsharma82/ElegantOTA/blob/master/src/ElegantOTA.cpp#L82

from elegantota.

brownrb avatar brownrb commented on May 26, 2024

respectfully, I disagree.
Please do not surmise what I need the srial port for. I had a simple request, which in my mind I framed politely and respectfully.

And a blanket reply fo to a user request to at least provide a means to turn it off, that is really not a solution. If you are unwilling to listen to users then I would suggest that this applciation is not worthy of making into the "Arduino" list.

from elegantota.

ayushsharma82 avatar ayushsharma82 commented on May 26, 2024

I think you misunderstood my comment. It was intended to be helpful rather than sounding bullish.

My reasoning for suggesting Serial1/SoftwareSerial was because Serial0 is also used by internal debug logging of ESP core. So one way or the other you will likely encounter some interference if something goes wrong.

Secondly, It's not a blanket reply, You said "I cannot find where to disable this", that's why I quoted the file where you can remove the lines because there is no actual way to remove it via a function call right now. ( and assumed a bit about the likely scenario in the back of my head )

The bottom line is: There is no way right now to do it other than the 2 solutions that I "suggested". I've got some pending bugs to fix in this library before I can hop on to new additions.

from elegantota.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.