Giter Club home page Giter Club logo

Comments (13)

ayonious avatar ayonious commented on August 24, 2024

That is really weird. I see this happening only in some Terminals. This looks really weird. Thanks for reporting @markg85

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Note that you actually see this in one of your examples too!
Screenshot

You barely see it due to the color theme the console uses, but you see it if you look very carefully. Perhaps that helps :)

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

You are right! I changed the color of my terminal and now I can see this more clearly!

I tested on old version. This was there from the beginning!

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Glad you can reproduce it!
I did look at it but the structure is a bit vague to me. From what i could figure out (which might still be wrong on my part) the horizontal lines are added in their default colors, the vertical lines are added with a specific color.

But i suppose you can figure it out much more quickly as the author of this neat package :)

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

You are welcome to make a neat PR :)

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Nice try, hehe. I leave that in your capable hands. I only "guessed" how it looks to be working but i didn't see a way to fix it without diving in.

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Wooooohooo!! Nice, that's fast!
And a huge commit for a seemingly small issue ;)

Any spoiler on when you release an updated NPM package with this fix?

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

hehe if you look carefully it was 2 lines of Code change 💅
but since its a basic feature update Every test needed to be updated.

Some basic feature update like this will take some time for testing! Feel free to test it out yourself to make the process faster!

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Just tried it locally (yarn build and copy that over my existing install of this package). It looks just as i would expect it. Borders with a single color! Sweet!

But... What if i want to give the borders a different color? How do i do that?

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

I think this is what your are looking for.
https://console-table.netlify.app/docs/doc-border-design

from console-table-printer.

markg85 avatar markg85 commented on August 24, 2024

Yep! Thank you!

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

🎉 This issue has been resolved in version 2.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from console-table-printer.

ayonious avatar ayonious commented on August 24, 2024

released on 2.11.1

from console-table-printer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.