Comments (9)
Closing this since it doesn’t seem to be worth pursuing, or at least not everybody feels 100 % comfortable with this :)
from ayo.
It's a bit safer with that change though. It makes it harder to tamper with the value.
Personally I see no reason to omit these commits, but I'm not hard opposed to it.
from ayo.
Seems ok? Do you want to keep them out for ever, or just until such time as we feel like doing bumping our semver major number?
from ayo.
So … assuming our release tooling is going to work like Node’s, what I’d do is revert them in master
. They’d be excluded until somebody reverts the reverts ;)
from ayo.
sounds good, I guess my only remaining question is how to keep track of things that have been kept out? I guess we could just search the reverts at some later point, but we'd still need to remember / write that down somewhere.
from ayo.
I'm confused why the EOL change in particular seems problematic - are people overwriting os.EOL such that them switching from assignment to defineProperty is problematic?
from ayo.
@sandfox Our release tooling should be pretty good at picking up commits that we have in our branches but Node doesn’t. :)
@ljharb I don’t know for sure. It’s a minor change, sure. But it also changes something that has worked basically forever, and I think we should have a better reason to justify changing that than “this should have been different from the beginning”.
from ayo.
Gotcha. I'd assume it can avoid issues with someone unintentionally mutating the core os
object.
Has anyone run an npm search to determine if anything would break? Change for the sake of change seems just as bad as reverts solely for the sake of avoiding change :-)
from ayo.
Has anyone run an npm search to determine if anything would break? Change for the sake of change seems just as bad as reverts solely for the sake of avoiding change :-)
Node usually already does such things.
Neither of these seem particularly detrimental to me.
from ayo.
Related Issues (20)
- fs.copyDirectory HOT 1
- Ayo.js Core Team meeting 2017-10-13 HOT 3
- where are the missing devs HOT 3
- Discord invite has expired HOT 3
- what is ayo? HOT 7
- what is the rationale for this project.. HOT 2
- Compiling for Android
- COC violates Code of Conduct HOT 1
- ded projekt? HOT 4
- Summary of resolved issues? HOT 2
- Project status?
- Update references to default branch to `latest` HOT 1
- Define clear goals/motivations of the Ayo.js project HOT 11
- Is ongoing interoperability with Node.js a requirement for Ayo? HOT 11
- Sub-team governance issue HOT 11
- Windows builds HOT 2
- First core team meeting! HOT 27
- Create an initial release HOT 3
- contributing.md changes that we may want to backport HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ayo.