False Duplicate Package Name panic about gocov HOT 10 CLOSED

Thanks for reporting the issue. Is there a package or code snippet you can provide that illustrates the problem? I assume it's due to Issue #3, but can't be sure.

I don't have regular Internet access at home right now, so it might be a little while before I get to fix this.

from gocov.

Hi Andrew,

Sorry for the less than timely response. So it does not seem to be the same
issue as #3. In your bug there looks like there is a name conflict across
different packages causing the issue. However, I run the test command on a
single package and it scans the files and it logs them multiple times in
duplicate package records. I have attached the json output. Hope this
helps. Let me know if I can provide any other information.

Keep up the great work on this project. Thanks.

Regards,

John Calabrese

2012/11/5 Andrew Wilkins [email protected]

Thanks for reporting the issue. Is there a package or code snippet you can
provide that illustrates the problem? I assume it's due to Issue #3#3,
but can't be sure.

I don't have regular Internet access at home right now, so it might be a
little while before I get to fix this.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10095227.

from gocov.

Unfortunately Github doesn't do attachments on issues, so I guess it got eaten by the mail server. Could you please copy it into pastebin and copy the link here? Thanks.

from gocov.

Also, if you could run gocov test with the "-v" flag, that might provide some additional insight. i.e. gocov test -v
This lists the packages that gocov is instrumenting.

from gocov.

Hi Andrew,

I have included a link to the output in pastebin. Let me know if I can
provide any other information.

http://pastebin.com/rjEsADjy

Regards,

John Calabrese

2012/11/15 Andrew Wilkins [email protected]

Also, if you could run gocov test with the "-v" flag, that might provide
some additional insight. i.e. gocov test -v
This lists the packages that gocov is instrumenting.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10399350.

from gocov.

Thanks, John. I haven't gleaned much from that - it's not making much sense to me how this could happen.
Is the source for yahooDataModels something you can share? If I can reproduce the error then it'll be much easier to identify cause.

from gocov.

Hi Andrew,

I figured out what the issue was. In one of my test files I was,
incorrectly, importing the package I was testing, so basically the package
was importing a copy of itself. This bug in my code was somehow manifesting
as a duplicate package entry after running your gocov test on the package.
I'm not sure how this even compiled in the first place but, I removed the
incorrect import and gocov was outputting the proper test json.

Thanks for your support on this matter, especially since the issue was on
my end.

Regards,

John Calabrese

2012/11/19 Andrew Wilkins [email protected]

Thanks, John. I haven't gleaned much from that - it's not making much
sense to me how this could happen.
Is the source for yahooDataModels something you can share? If I can
reproduce the error then it'll be much easier to identify cause.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10503074.

from gocov.

Hi John,

Thanks for the update. I'm glad you sorted it out; sorry I couldn't be of much assistance.

Do you mean you had a package P, and test file with package name P_test, which was importing P? Or the test file also had package name P? If the latter, that's odd; I don't see how it would even get past "go test", which should complain about a cyclic import. Which version of Go are you using?

Regards,
Andrew

from gocov.

Hi Andrew,

ex. file_test.go was in package P and also Importing package P. The package
was a local import using a relative reference. I've read about several
issues regarding local imports and relative references. the most relevant
mentioning 2 copies of a package being the result. I've included a link.
Also, I'm using go version go1.0.2.

https://codereview.appspot.com/5787055

-John

2012/11/27 Andrew Wilkins [email protected]

Hi John,

Thanks for the update. I'm glad you sorted it out; sorry I couldn't be of
much assistance.

Do you mean you had a package P, and test file with package name P_test,
which was importing P? Or the test file also had package name P? If the
latter, that's odd; I don't see how it would even get past "go test", which
should complain about a cyclic import. Which version of Go are you using?

Regards,
Andrew

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10785713.

from gocov.

Ah! Thank you very much for investigating and explaining this.
I'll look into adding some additional checks in gocov, so others don't get
tripped up.

Regards,
Andrew

On Wed, Nov 28, 2012 at 9:54 AM, xchapter7x [email protected]:

Hi Andrew,

ex. file_test.go was in package P and also Importing package P. The
package
was a local import using a relative reference. I've read about several
issues regarding local imports and relative references. the most relevant
mentioning 2 copies of a package being the result. I've included a link.
Also, I'm using go version go1.0.2.

https://codereview.appspot.com/5787055

-John

2012/11/27 Andrew Wilkins [email protected]

Hi John,

Thanks for the update. I'm glad you sorted it out; sorry I couldn't be
of
much assistance.

Do you mean you had a package P, and test file with package name P_test,
which was importing P? Or the test file also had package name P? If the
latter, that's odd; I don't see how it would even get past "go test",
which
should complain about a cyclic import. Which version of Go are you
using?

Regards,
Andrew

—
Reply to this email directly or view it on GitHub<
https://github.com/axw/gocov/issues/13#issuecomment-10785713>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-10786533.

Andrew Wilkins
http://awilkins.id.au

from gocov.