ComponentLocator does not resolve beans from Spring Parent Context about axonframework HOT 6 CLOSED

Hi @smcvb,

To be honest, I think you're the only team I know that uses Spring's hierarchy with Axon Framework.

Probably :-)

Just out of curiosity, but do you have tests in your environment to validate whether the hierarchy is adhered too?
And, if so, do you think it's feasible to introduce such an enhancement to Axon Framework?

No, unfortunately we do not have a general test for this. We are spotting those issues "by accident", when we discover that something does not work as expected.

To conclude my post here: would you be up for another PR, @nils-christian?

In general, yes. Unfortunately it seems that the 4.8.x branch is currently not stable. At least in Eclipse I see various compile errors and building via Maven is not possible due to test failures. Building without tests is not possible as some modules use the test jars.

That makes it currently not possible to develop the PR.

(Frankly speaking: The absence of some kind of locally available quick install makes it very cumbersome to develop a PR for the Axon framework as an external developer)

Best regards

Nils

from axonframework.

Hi @smcvb,

I moved my description of the issues regarding the import in Eclipse to #2865.

Best regards

Nils

from axonframework.

Thanks for spotting this once more, @nils-christian.
To be honest, I think you're the only team I know that uses Spring's hierarchy with Axon Framework.
Or, at least the only one I know of.

Just out of curiosity, but do you have tests in your environment to validate whether the hierarchy is adhered too?
And, if so, do you think it's feasible to introduce such an enhancement to Axon Framework?

As it stands, we do not propagate to support that we support this feature of Spring necessarily.
Hence why I am changing the type from "bug" to "enhancement," by the way.
Granted, we've resolved the referred-to issues for you and Oliver (and team) too, so I don' see why we wouldn't do this one either.

To conclude my post here: would you be up for another PR, @nils-christian?
As it stands we're hard at work with console.axoniq.io, making it so that I need to lower the priority on this issue quite some.

from axonframework.

That's...interesting, and bothersome!

The project compiles fine from my end. Granted, I work with it daily, so it's to be expected. 😅

The one thing that may cause the compile issues on your end is the relatively recent introduction of JDK11 and JDK17-specific modules, purely for testing.
However, I thought you had provided PRs for AF 4.7.x too...which I may recall incorrectly.

What I do in my IDE, is set the language level to JDK8, but compile and develop against JDK17.
From there, the GitHub Actions pick up the validation whether it work's on JDK8, JDK11, and JDK17 for me.

(Frankly speaking: The absence of some kind of locally available quick install makes it very cumbersome to develop a PR for the Axon framework as an external developer)

What would you recommend as a "quick install," @nils-christian?
You have frequented this repository in the last couple of versions with issues and provided pull requests.
The fact you refrain from doing so right now is, frankly speaking, sad news to me. :-[

So, if there are improvements we can make to ease contribution, I'm all up for it!
It would be sad to no longer get these valuable contributions from others, thus including you.

from axonframework.

Given the impediment you're facing, @nils-christian, I went ahead and made a pull request to resolve the predicament.
I have tested the changes against my own sample project and the sample you gave above, with success.
You can find the PR here, if you're curious.

from axonframework.

I'm closing this issue since pull request #2870 resolves it.
Thanks again for sharing this with us, @nils-christian!

from axonframework.