Null not possible about laravel-postal-code-validation HOT 6 CLOSED

@schonhoff I've merged the changes and tagged it as v3.1.1

from laravel-postal-code-validation.

Thank you for the bug report @schonhoff. The correct behaviour for receiving null should be validation failing, bail should not be necessary (except if you want to suppress multiple validation errors on the same input) so this sounds like a bug.

Could you tell me you Laravel and Postal code validation versions?

from laravel-postal-code-validation.

Hello,

no problem. I hope I can help you with this information:

"name": "axlon/laravel-postal-code-validation", "version": "v3.1.0",

"name": "laravel/framework", "version": "v8.6.0",

My current validation rule for my postal code field:

['bail', 'required', 'postal_code:DE']

As you noticed correctly bail shouldn't be necessary, but currently it is for me.
If I return nothing (null) to the validation

$validator = Validator::make($data, $rules, $messages);
if($validator->fails())

throws the error message. With the fixed code on my first post I don't get an error and the validation works like you described.

from laravel-postal-code-validation.

Just a hint:

on your src\Extensions\PostalCode Class you are using
public function validate(string $attribute, ?string $value, array $parameters)
on the validate function but in the function passes you are calling there needs to be a string.

public function passes(string $countryCode, string ...$postalCodes): bool

I guess that this is the error. Maybe it is because of php 7.4 that I'm currently using.

from laravel-postal-code-validation.

@schonhoff Could you review the changes I made in PR linked above? I think they should fix your issue. Note that validation will still pass if the given country has no pattern and null is passed

from laravel-postal-code-validation.

@axlon copied the changes to my local system and it seems like it fixes the issue. Thanks for the fast fix!

from laravel-postal-code-validation.