Comments (3)
Indeed thats what the documentation says !
Few versions ago, one of @awspilot/dynamodb dev dependencies
had vulnerable deps ( that pushed me on page 13 in search results )
and the only way to control the dependency tree was
to use npm-shrinkwrap to lock down the vuln package to specific version.
This is when the file was added, I see it as a way of protecting
the library users from installing vulnerable dependencies
( which I believe is my responsibility ).
On the other hand npms.io ( behind npmjs.com search )
will rank you lower if you don't have one .
https://nodejs.org/en/blog/npm/managing-node-js-dependencies-with-shrinkwrap/
says: Run "npm shrinkwrap", commit the new npm-shrinkwrap.json, and publish your package.
Please let me know if you have any other references saying including it is bad.
I could just add npm-shrinkwrap to .npmignore but I wont do that now.
from dynamodb-oop.
another post http://npm.github.io/using-pkgs-docs/shrinkwrap/index.html
also says Commit the new npm-shrinkwrap.json, and publish your package.
from dynamodb-oop.
I'm closing the issue for now as I can;t find evidence
that including it in the package is bad practice
from dynamodb-oop.
Related Issues (20)
- Expression error when using a having('key').between(1, 10) HOT 10
- update or insert is modifying my data object HOT 4
- Raising an issue to tell ... HOT 1
- Support for updating nested json in dynamoDB HOT 1
- Promise support HOT 4
- Boolean "false", becomes "undefined" HOT 6
- Docs scroll to top HOT 2
- Cannot use region provided in config.json HOT 2
- Executing an average operation on the DB HOT 1
- "OR" support in scan HOT 3
- Looping Scan with async/await question. HOT 3
- Recursive scan example HOT 6
- Update table HOT 2
- Support to pass array of attribute names for "select" operand HOT 2
- Support Dynamo Transactions HOT 6
- BatchInsert not working HOT 2
- transact.insert is undefined on Lambda Layer HOT 2
- Support AWS SDK v3 HOT 2
- Disable Table Schema Table Warning HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynamodb-oop.