Giter Club home page Giter Club logo

Comments (3)

adrianpraja avatar adrianpraja commented on August 17, 2024

Indeed thats what the documentation says !

Few versions ago, one of @awspilot/dynamodb dev dependencies
had vulnerable deps ( that pushed me on page 13 in search results )
and the only way to control the dependency tree was
to use npm-shrinkwrap to lock down the vuln package to specific version.

This is when the file was added, I see it as a way of protecting
the library users from installing vulnerable dependencies
( which I believe is my responsibility ).

On the other hand npms.io ( behind npmjs.com search )
will rank you lower if you don't have one .

https://nodejs.org/en/blog/npm/managing-node-js-dependencies-with-shrinkwrap/
says: Run "npm shrinkwrap", commit the new npm-shrinkwrap.json, and publish your package.

Please let me know if you have any other references saying including it is bad.
I could just add npm-shrinkwrap to .npmignore but I wont do that now.

from dynamodb-oop.

adrianpraja avatar adrianpraja commented on August 17, 2024

another post http://npm.github.io/using-pkgs-docs/shrinkwrap/index.html
also says Commit the new npm-shrinkwrap.json, and publish your package.

from dynamodb-oop.

adrianpraja avatar adrianpraja commented on August 17, 2024

I'm closing the issue for now as I can;t find evidence
that including it in the package is bad practice

from dynamodb-oop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.