Giter Club home page Giter Club logo

Comments (8)

neoandroid avatar neoandroid commented on August 15, 2024

I've hit the same problem with the "Essential" property of a container definition. Is there a suggested solution? I'm happy to implement a workaround if you point me how we should resolve this issue.
Shouldn't these kind of fields be pointers? That way it should work as users expect.

from goformation.

mumoshu avatar mumoshu commented on August 15, 2024

@deoxxa @neoandroid Can we probably close this as resolved, as @majasb has contributed fixes for booleans and numbers in #133?

from goformation.

karnauskas avatar karnauskas commented on August 15, 2024

Having similar problem:

			Monitoring: &cloudformation.AWSEC2LaunchTemplate_Monitoring{
				Enabled: false,
			},

is rendered as following in yaml output

        Monitoring: {}

from goformation.

rhyselsmore avatar rhyselsmore commented on August 15, 2024

I've had the same issue with the AWSLogsSubscriptionFilter type. It has a parameter named FilterPattern. In order to catch all events, you simply supply an empty string.

However, due to empty string being a null string in Go, the value is not included in the generated template.

from goformation.

ndeloof avatar ndeloof commented on August 15, 2024

ECS ContainerDefinition Essential attribute is not required and of type boolean, but then omitempty prevent to set value to false. Issue with that is that the actual API default is true : "If this parameter is omitted, a container is assumed to be essential.".
So there's no way to declare a non-essential containerdefinition

from goformation.

PaulMaddox avatar PaulMaddox commented on August 15, 2024

I think it's clear this library needs to transition to using pointers instead of values. It's causing a ton of rough edges. Unfortunately it may be a while before I have time to implement it, however if anyone else wants to have a go in the meantime i'll happily accept a PR.

from goformation.

xrn avatar xrn commented on August 15, 2024

@rubenfonseca if I am correct this would be solved in v6 looking on behaviour of my issue - #474

from goformation.

rubenfonseca avatar rubenfonseca commented on August 15, 2024

That's right! Thank you for pointing this our @xrn.

from goformation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.