Searching with a valid search parameter but an invalid value; should return 400 about fhir-works-on-aws-search-es HOT 5 CLOSED

Ah, yes. Thank you for calling this out Emil. Currently we're doing a string match when searching for date values, which is why this occurs. We need to update our code to fully support searching by dates. I'll add this Bug to our backlog.

By the way, what version of FWoA are you running? When I ran the code from this version, with an invalid _lastUpdated search param it responds with a 200 HTTP status.

from fhir-works-on-aws-search-es.

Hi @nguyen102 we're using an alternate deployment repo, so unfortunately I can't point directly to a link that shows all the versions, but here they are (on the left are our tags, on the right your tags/commit hashes):

fhir-works-on-aws-interface 21.2.1 -> v7.1.0
fhir-works-on-aws-routing 21.2.1 -> v4.0.3
fhir-works-on-aws-authz-smart 21.2.1 -> v0.1.2
fhir-works-on-aws-persistence-ddb 21.2.2 -> v3.2.1
fhir-works-on-aws-search-es 21.2.2 -> v2.1.0

We also have a slightly different implementation of the the SMARTHandler, it's possible that this 403 HTTP status is coming from that code instead of the search service. I can track that down further, if you think the expected behavior here is a non-error response from the search service.

from fhir-works-on-aws-search-es.

Looks like you have the latest released version of search service. And yep, I can confirm that no error is thrown by search service when an invalid search parameter value is provided.

from fhir-works-on-aws-search-es.

@nguyen102 looks like this other issue is related if not the same: #17

Does this mean that the ES service should return a 400 now instead?

from fhir-works-on-aws-search-es.

Ah that issue is slightly different. Search will return a 400 if we're trying to search on a field that doesn't exist. For example if we search ?foo=1234 that will throw an error. In this case though, we're searching on an invalid date value for a valid search parameter (?_lastUpdated=foo), which will return in a 200 (with no results).

from fhir-works-on-aws-search-es.