When click the object in the explorer list, the open window was blank with wrong url f

I noticed the same issue with the af-south-1 region. This fix <a href="https://gbif-o

Can't support AWS China Region url. about aws-js-s3-explorer HOT 2 OPEN

awslabs commented on July 23, 2024

Can't support AWS China Region url.

from aws-js-s3-explorer.

Comments (2)

dkstsh commented on July 23, 2024

fix it:
function object2hrefvirt(bucket, key) {
var enckey = key.split('/').map(function (x) {
return encodeURIComponent(x);
}).join('/');

    if (AWS.config.region === "us-east-1") {
        return document.location.protocol + '//' + bucket + '.s3.amazonaws.com/' + enckey;
    }

** fix this else if (AWS.config.region === "cn-north-1") {
return document.location.protocol + '//' + bucket + '.s3.' + AWS.config.region + '.amazonaws.com.cn/' + enckey; **

    } else {
        return document.location.protocol + '//' + bucket + '.s3-' + AWS.config.region + '.amazonaws.com/' + enckey;
    }
}

from aws-js-s3-explorer.

MattBlissett commented on July 23, 2024

I noticed the same issue with the af-south-1 region. This fix seems to work.

I'll copy the change above, since the formatting is broken. s3- is changed to s3.

    function object2hrefvirt(bucket, key) {
        var enckey = key.split('/').map(function(x) { return encodeURIComponent(x); }).join('/');

        if (AWS.config.region === "us-east-1") {
            return document.location.protocol + '//' + bucket + '.s3.amazonaws.com/' + enckey;
        } else {
            return document.location.protocol + '//' + bucket + '.s3.' + AWS.config.region + '.amazonaws.com/' + enckey;
        }
    }

    function object2hrefpath(bucket, key) {
        var enckey = key.split('/').map(function(x) { return encodeURIComponent(x); }).join('/');

        if (AWS.config.region === "us-east-1") {
            return document.location.protocol + "//s3.amazonaws.com/" + bucket + "/" + enckey;
        } else {
            return document.location.protocol + "//s3.' + AWS.config.region + '.amazonaws.com/" + bucket + "/" + enckey;
        }
    }

I would submit a PR, but I spotted this:

aws-js-s3-explorer/index.html

Lines 688 to 690 in 4de1fd0

 // The following is also a legal form, but we do not support it, so 

 // you should use s3-eu-central-1 rather than s3.eu-central-1: 

 // - bucket3.s3.eu-central-1.amazonaws.com

and I don't know enough about AWS URLs to be sure of all the possibilities. s3-eu-central-1 works, but s3-af-south-1 does not.

(The URLs don't seem to be consistent between regions, e.g. https://gbif-open-data-eu-central-1.s3-eu-central-1.amazonaws.com/occurrence/2021-04-13/citation.txt and https://gbif-open-data-eu-central-1.s3.eu-central-1.amazonaws.com/occurrence/2021-04-13/citation.txt both work, with either s3-eu-central-1 or s3.eu-central-1, but https://gbif-open-data-af-south-1.s3-af-south-1.amazonaws.com/occurrence/2021-04-13/citation.txt doesn't work; https://gbif-open-data-af-south-1.s3.af-south-1.amazonaws.com/occurrence/2021-04-13/citation.txt does).

from aws-js-s3-explorer.

Can't support AWS China Region url. about aws-js-s3-explorer HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// The following is also a legal form, but we do not support it, so
	// you should use s3-eu-central-1 rather than s3.eu-central-1:
	// - bucket3.s3.eu-central-1.amazonaws.com