Comments (2)
Hello,
In 0.2.0 we have updated the way CloudFormation CreateChangeSet errors were handled to make it more informative when an error was to occur. In your current situation, it sounds like a Change Set is being created on the pipeline stack but is failing to create the change set due to some error occurring.
Once it failed, it was being cleaned up before you could check why the change set creation was failing. This might be due to missing the parameters in parameter store that the GitHub j2 template is expecting (auth token, web hook secret). Ensure you have created the required parameters in parameter store as outlined in the docs (also updated in 0.2.0).
I have created a CodeCommit based pipeline and then updated it to a GitHub pipeline in the current 0.2.0 release without an error occurring, I’ve also tested a failure (not adding required parameters to Parameter Store) and ensured the stack errors as intended.
There was also a small fix in 0.2.0 for the github-cloudformation.j2 template which resolves an issue with branches not triggering the webhook correctly so please try with the latest set of changes and let me know if this resolves the problem.
from aws-deployment-framework.
What you are saying makes a lot of sense @bundyfx, and with #10 it should no longer be silently failing, so this issue can be closed. Thank you for the quick response 🙌
from aws-deployment-framework.
Related Issues (20)
- ADF support for CDK v2 HOT 8
- [Feat]: Update CDK Sample App to modern version HOT 1
- [Feat]: Introduce an ADF pipeline region SSM Parameter store value in raw form
- [Feat]: Do not hardcode DEFAULT_CODEBUILD_IMAGE
- There is already a Construct with name 'iam-target-1-wave-0' in Stack [iam]
- [Feat]: Re-enable cfn-lint HOT 2
- [Feat]: Event based detection method for pipeline with S3 data source
- [Feat]: Support Deployment Maps in Source repositories
- [Bug]: Long and similar pipelines names in same deployment map prevents pipeline from being created
- [Bug]: terraform plan doesn't catch errors
- [Bug]: aws-deployment-framework-base pipeline fails HOT 5
- [Bug]: Description of EventBridge Rules for Completion Triggers shows variables placeholders
- [Bug]: DeleteDefaultVPC fails with OptInRequired HOT 2
- [Feat]: New release HOT 2
- [Bug]: Parameter "deployment_account_id" into deployment account's parameter store HOT 2
- [Feat]: Terraform variables per region
- [Bug]: Account Based Terraform variables do not work
- [Feat]: Improve auto-create-repository behaviour within Deployment Map Definition HOT 1
- [Feat]: Add Python isort and black linters. HOT 2
- [Feat]: Enhanced Targetting via Tags HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-deployment-framework.