Comments (6)
allenmichael
commented on August 19, 2024
1
Sounds like good reasoning to me! I arranged the order to be the same. I'll switch the other Lambda actions to use the OutputChannel too depending on Steve's feedback when he gets back, but this feels like the right path forward to me too.
from aws-toolkit-vscode.
allenmichael
commented on August 19, 2024
Hey @steveataws, I was thinking about this one and wondered what you thought about using the Output window in the bottom panel. I did some coding around the idea and you can create an Output Channel and make it appear. Here's a screenshot of what it could look like:
from aws-toolkit-vscode.
kiiadi
commented on August 19, 2024
Nice! I like moving the response to the output - we're following that same pattern in the JetBrains work too. It fits better with what customers expect!
For the JB work we spat out the logs first and then the response - we should probably sync up with what we're outputting so that we have a consistent experience across the IDEs.
@abrooksv is working on the JB side of it.
PS: Looks like the build is failing with the following error:
src/extension.ts(20,9): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(86,29): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(87,29): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(92,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(93,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(94,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(95,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(96,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(97,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(98,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(99,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(100,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(102,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(103,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
src/lambda/commands/invokeLambda.ts(104,33): error TS2339: Property 'lambdaOutputChannel' does not exist on type 'typeof ext'.
from aws-toolkit-vscode.
allenmichael
commented on August 19, 2024
Good to know about JB work, that's an easy win to keep things consistent. Thank you for the build error too! I couldn't get access to the build pipeline to see the error :-) Lemme make those changes.
from aws-toolkit-vscode.
kiiadi
commented on August 19, 2024
Sweet! Yeah it'd be cool for you and Austin to sync up so that we can get a consistent experience. I think he's reasoning for putting the logs first and the output second is that the logs might be longer and the output would then scroll off the screen.
from aws-toolkit-vscode.
abrooksv
commented on August 19, 2024
I did logs then function error if present. Then formatted json output payloud. My reasoning was because the output scrolls due to appends and I figured the most important thing was the result of the lambda so always wanted it visible
from aws-toolkit-vscode.
Related Issues (20)
- Amazon Q code completion HOT 1
- Translate a piece of code into another code language HOT 3
- Upgrade to vscode-l10n HOT 1
- AWS Toolkit render state machine visual rendering wrong state machine despite showing in the list HOT 5
- Unable to use Amazon Q! HOT 5
- Unable to login to amazon q developer using vs code HOT 6
- SamLaunchRequestError when running aws-sam debug configuration in VScode HOT 6
- Crashes in the background, often. Usually right after locking the editor. HOT 6
- Sign in to get started doesn't work on Code Editor in SM Studio HOT 1
- Automatically generate commit messages
- Sign in to AWS Toolkit in Visual Studio Code with AWS IAM Identity Center - Start URL not accepted HOT 2
- CLI does not work in codespaces/devcontainers HOT 1
- Issue when using the "Open Dev Environment" command in the CODECATALYST pane
- Jupyter Notebook
- AWS Toolkit VS Code Plugin does not connect to S3 bucket
- @workspace attempts to index python virtual envs (.venv, venv) HOT 1
- Expose a synchronous API to Amazon Q allowing introspecting current session state. HOT 1
- Amazon Q response glitch
- Quick link to update Q extension to the latest if is outdated HOT 1
- Support go to console for Lambda
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-toolkit-vscode.