Correct access/secret key env variable names in EnvironmentVariableCredentialsProvider? about aws-sdk-java HOT 16 CLOSED

Yes, my question was more about the authoritative environment variable name rather than the right English name. Do these actually vary, maybe not by design but in fact? For example that second like definitely shows setting "AWS_ACCESS_KEY" and not "AWS_ACCESS_KEY_ID" as the official name for the EC2 command line tools. If it's just that the SDK uses a different property name, that's OK by me; was just checking that this is intentional.

from aws-sdk-java.

Hey Sean, if you log into your AWS account and go to the AWS security credentials page:
https://portal.aws.amazon.com/gp/aws/securityCredentials

you'll see the authoritative names for these:
Access Key ID
Secret Access Key

Tools often abbreviate these to:
Access Key
Secret Key

but there are a few variations out there, as you noticed.

from aws-sdk-java.

Agree this has been a bit annoying... especially since the aws ruby SDK uses AWS_ACCESS_KEY_ID : https://github.com/aws/aws-sdk-ruby/blob/master/lib/aws/core/credential_providers.rb

from aws-sdk-java.

So, EnvironmentVariableCredentialsProvider picked the authoritative name for one ("AWS_ACCESS_KEY_ID") but the conventional name for the other ("AWS_SECRET_KEY")? That's even more confusing.

Seems like, with all the confusion out there, plus needing to maintain backwards compatibility, the best thing to do would be for this to check both the authoritative and conventional environment variables.

from aws-sdk-java.

Closing as this was merged.

from aws-sdk-java.

Why was this closed? AFAICT only AWS_SECRET_KEY is referenced from:

https://github.com/aws/aws-sdk-java/blob/master/src/main/java/com/amazonaws/auth/EnvironmentVariableCredentialsProvider.java

@wmatveyenko what merge are you talking about?

from aws-sdk-java.

(Specifically, I believe EnvironmentVarialbeCredentialsProvider should check both AWS_SECRET_KEY and AWS_SECRET_ACCESS_KEY.)

Maybe I'll just go make a pull request...

from aws-sdk-java.

I apologize for closing this in error. I was reading the comments and mistook the referenced pull request as a pull request to the SDK. Please submit a pull request to fix this issue.
Thanks!

from aws-sdk-java.

Closing this issue for now. When you have the pull request, feel free to reopen.

from aws-sdk-java.

Pull request submitted--not sure I can reopen the issue. But let me know if you have any feedback. Thanks!

from aws-sdk-java.

Reopening for you :-)

from aws-sdk-java.

Resolving again in favour of the pull request.

from aws-sdk-java.

I saw that 1.6.2 got released a few days ago, but it looks like this change was not in it.

You seem to be making source drops from some internal repository.

Which is fine, but did this patch not get submitted to your internal repository?

from aws-sdk-java.

Hey Stephen, sorry for the confusion on this one! The issue was closed, so I understand why you'd expect the fix to show up in a release, but the pull hadn't actually been merged in yet.

But... I just went ahead and merged in your pull request, so you'll definitely see this fix go out in the next SDK release!

Thanks again for taking the time to report this and send us a fix!

from aws-sdk-java.

Sounds great, thanks Jason!

from aws-sdk-java.

List of all environment variables: http://docs.aws.amazon.com/cli/latest/userguide/cli-environment.html

from aws-sdk-java.