Proposal: Add the task id as a label on the container. about amazon-ecs-agent HOT 5 CLOSED

As an example for the first step of this of adding the task arn/uuid as a label, this is what I was thinking of: https://github.com/aws/amazon-ecs-agent/compare/master...remind101:task-label?expand=1.

from amazon-ecs-agent.

I think this looks like a great idea and would be very happy to see a pull request! Please note that any pull requests will be accepted under the Apache 2.0 license.

I think the following three labels would make sense to be automatically applied:

• com.amazonaws.ecs.task-arn
• com.amazonaws.ecs.task-definition-arn
• com.amazonaws.ecs.container-name

With respect to your question about supporting labels within task definitions, can you expand a bit on your use case here? Is your primary use-case just logging metadata? Are you looking to make scheduling decisions or IAM policies based on these?

from amazon-ecs-agent.

With respect to your question about supporting labels within task definitions, can you expand a bit on your use case here?

Sure! For my use case, it would only serve as logging metadata (for consumption by logspout/heka). Specifically, I'd like to set some labels on the container when it's run com.<place>.app-name, com.<place>.process-type, then I would have the labels extracted and added as structured data in syslog messages generated by logspout and shuttled off to sumo/papertrail for aggregation. Having the labels added to the log messages will make it significantly easier to query logs.

For this particular use case, the labels couldn't be added within the Dockerfile via the LABEL directive because the image could be used within multiple ecs services with a different process-type and app-name labels.

I think this looks like a great idea and would be very happy to see a pull request!

On it :).

from amazon-ecs-agent.

Released with v1.2.0.

from amazon-ecs-agent.

🤘

from amazon-ecs-agent.