Chaining with slots creates a loop about qnabot-on-aws HOT 7 CLOSED

Hi @amendlik Thanks for reporting this
We'll look into this and get back to you

from qnabot-on-aws.

Hello @jangidms - any updates on this? I can work on the fix if you can point me in the right direction.

from qnabot-on-aws.

Hi @amendlik
I looked into this scenario and I see that currently Document Chaining is not supported when using intent & slots. It is working as expected.
When processing request with QnaIntent, QnABot injects qid in the request (Link to Request Parsing Code)
When evaluating conditional chaining, QnABot updates the question in the request to chaining question (Conditional Chaining Code)
But since request also has qid field, that takes precedence over question when making OpenSearch request (OpenSearch Request logic)

You could try to customize QnABot as per your use case, or open a new enhancement request which we'll add to our backlog

from qnabot-on-aws.

@bobpskier I've been testing a solution that just deletes qid from the structure by adding this code to evaluateConditionalChaining()

    if(req.hasOwnProperty('qid')) {
        delete req['qid'];
    }

It's working fine so far. I have not encountered any negative effects.

from qnabot-on-aws.

@amendlik I'd probably implement something similar in evaluateConditionalChaining.js starting at line 100

if (next_q) {
        req.question = next_q;
        if (next_q.toLowerCase().startsWith('qid::')) {
            _.set(req,'qid', next_q.substr(5));
        } else {
            _.set(req,'qid', undefined);
        }
        [req, res, hit2, errors] = await getHit(req, res);
    }

This updates req.qid to be the actual target qid of the chaining config if it is specified as a "qid::" or removes qid if not specified in that format.

The intent/slot mechanism is not a good citizen in the word of QnABot chaining. It looks like it can only be used in the first qid that kicks off a series of chained qids. If in the middle of the chain of questions, a qid is specified that also uses intents/slots, the chaining mechanism will skip right over asking to resolve the slot values. The intent/slot mechanism only works at the beginning of the chain when Lex can call QnABot fulfillment using a DialogCodeHook with the intent/slots as the context.

If you want to conditionally ask for values in one of more qids via chaining, it is better to use ElicitResponse bots as they support the concept of chaining.

from qnabot-on-aws.

This fix is working well for us. @bobpskier, do you want to upstream that, or would you like me to do it?

from qnabot-on-aws.

@amendlik can you please submit a PR if you want us to consider as improvementÉ
Closing this

from qnabot-on-aws.