Giter Club home page Giter Club logo

Comments (9)

jeffsec-aws avatar jeffsec-aws commented on August 20, 2024 2

Hi,
It is related to the loading of https://js.arcgis.com/4.3/dojo/dojo.js from ride.html

The version 4.3 references the public item ID 0e02e6f86d02455091796eaae811d9b5 while from version 4.5 it points to 92c551c9f07b4147846aae273e822714.

So changing in aws-serverless-webapp-workshop/resources/code/WildRydesVue/src/views/Ride.vue from @import 'https://js.arcgis.com/4.3/esri/css/main.css'; to @import 'https://js.arcgis.com/4.23/esri/css/main.css should solve it.

Cool way to force consumers to update their library dependencies.

Jeff

from aws-serverless-webapp-workshop.

boyney123 avatar boyney123 commented on August 20, 2024

Thanks for raising the issue @robertjsandor , I will take a look and get back to you

from aws-serverless-webapp-workshop.

robertjsandor avatar robertjsandor commented on August 20, 2024

from aws-serverless-webapp-workshop.

jeffsec-aws avatar jeffsec-aws commented on August 20, 2024

I am still running some tests. Seems like 4.23 changes the behavior of the Click (from pickup location to zoom in).

I am testing with 4.5 to maintain the initial behavior. I will try to narrow down the best version you go with, but you can start with 4.5.

from aws-serverless-webapp-workshop.

robertjsandor avatar robertjsandor commented on August 20, 2024

from aws-serverless-webapp-workshop.

boyney123 avatar boyney123 commented on August 20, 2024

Thanks for taking a look @jeffsec-aws, would you recommend we update to 4.5 for now? Or wait until you have found the best version to go for?

I can also take a look, but feels like you have the best context at the moment, let me know if you need any help.

@jeffsec-aws once you are happy are you OK to raise a PR with a fix?

from aws-serverless-webapp-workshop.

boyney123 avatar boyney123 commented on August 20, 2024

Strange, I just ran through the whole thing, tested on Chrome and Firefox and everything seems to be working for me?

I can request unicorns and see them come to my position fine.

I wonder if they have fixed something or not, @robertjsandor or @jeffsec-aws can you try again with the repo version as it is? Could you provide screenshots of the bug, and also the network tab (loading in the resource versions).

Also out of interest what browser versions are you using?

I can't seem to replicate the issue.

from aws-serverless-webapp-workshop.

pepecuencar avatar pepecuencar commented on August 20, 2024

Then is css line and script line?
It seems to work when i changed css line to 4.5 and script line to 4.5 too, thanks!!!

from aws-serverless-webapp-workshop.

Trent1900 avatar Trent1900 commented on August 20, 2024

my one worked on version 4.6. thanks very much, that bothered me for the last 20 hours.

from aws-serverless-webapp-workshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.