Giter Club home page Giter Club logo

Comments (5)

kmotohas avatar kmotohas commented on July 26, 2024

@Kumfert

Hi, I like this idea, but some cells are not working now, at least the cell below in xgboost_direct_marketing_sagemaker.ipynb.

# cell 01
conda update pandas

The comment (# cell 01) makes it assumed as a python cell so conda update pandas fails.

image

conda update pandas should be !conda update pandas -y now.

from amazon-sagemaker-immersion-day.

Kumfert avatar Kumfert commented on July 26, 2024

Good point @kmotohas . As far as I can tell, there's no automated acceptance tests for pull requests in this repo. Maybe that should be a separate issue?

from amazon-sagemaker-immersion-day.

vmehmeri avatar vmehmeri commented on July 26, 2024

This is causing issues for magic commands that need to be the first statement in a cell, just as %%time. In the Model Monitoring notebook this is used in cell 01 and it is throwing an error. I suggest cell numbering be done as a separate markup line above the cells

from amazon-sagemaker-immersion-day.

Kumfert avatar Kumfert commented on July 26, 2024

Hello. I like your suggestion. But when I considered the implementation, I'm concerned that it makes too many changes in the *.ipynb files. (Consider the case where there is not a markdown block preceding the code block).

A simpler alternative, is to simply omit the explicit numbers in any code block leading with %%. (Though the counter would still increment)

from amazon-sagemaker-immersion-day.

Kumfert avatar Kumfert commented on July 26, 2024

@vmehmeri Here's a PR for your consideration #44

from amazon-sagemaker-immersion-day.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.