Giter Club home page Giter Club logo

Comments (8)

charlesjiang-greengate avatar charlesjiang-greengate commented on August 27, 2024 1

Thank you very much looking into this issue. I will try to chase it up on 1Password's end.

from amazon-cognito-passwordless-auth.

charlesjiang-greengate avatar charlesjiang-greengate commented on August 27, 2024 1

Please close this issue. Fault is not with this library here.

1Password has been unresponsive on this issue

from amazon-cognito-passwordless-auth.

ottokruse avatar ottokruse commented on August 27, 2024

Thanks for the report.

This might be better directed at 1Password potentially though?

I don't use 1Password and can't reproduce this but let's try to see if we can locate and fix it with your help.

Question, how did you confgure the lib, what value are you using for debug?

Illegal invocation maybe caused by to the destructuring of response (from credential.response, maybe 1Password proxies it). Have a try changing our code directly inside your node_modules to:

debug?.("Created credential:", {
    credential,
    getTransports: credential.response.getTransports?.(), // `credential.response` instead of `response`
    getAuthenticatorData: credential.response.getAuthenticatorData?.(), // `credential.response` instead of `response`
    getPublicKey: credential.response.getPublicKey?.(), // `credential.response` instead of `response`
    getPublicKeyAlgorithm: credential.response.getPublicKeyAlgorithm?.(), // `credential.response` instead of `response`
});

Or it's because debug doesn't work like that and you need to call configure differently:

Do:

Passwordless.configure({
  ...,
  debug: console.debug.bind(console),
});

Instead of:

Passwordless.configure({
  ...,
  debug: console.debug,
});

(But there's other debug calls that you'd have run into earlier then so I doubt that is the issue.)

from amazon-cognito-passwordless-auth.

charlesjiang-greengate avatar charlesjiang-greengate commented on August 27, 2024

Hi @ottokruse , thanks for coming back to you. I think you are correct on this one, that this is likely to be caused by implementation bug with 1Password chrome extension. I will raise this issue with 1Password to see if they can fix it on their end.

debug is currently the default configuration which is debug: console.debug, I will give your suggestion a try and come back to you on this.

from amazon-cognito-passwordless-auth.

charlesjiang-greengate avatar charlesjiang-greengate commented on August 27, 2024

Justing reporting back:

credential.response.getAuthenticatorData() still returns the same error Uncaught TypeError: Illegal invocation.

Changing to debug: console.debug.bind(console), also didn't help.

Using debug console, I can see the following for response

image

from amazon-cognito-passwordless-auth.

charlesjiang-greengate avatar charlesjiang-greengate commented on August 27, 2024

This seems to be an existing issue someone has just raised with 1Password as well.

I am not sure if it is within the spec to be able to call getPublicKey() etc.

from amazon-cognito-passwordless-auth.

ottokruse avatar ottokruse commented on August 27, 2024

We only call that method if it's not null or undefined in which case it should work (as per spec: https://www.w3.org/TR/webauthn-2/#dom-authenticatorattestationresponse-getpublickey)

So yes this looks like an issue for 1Password

from amazon-cognito-passwordless-auth.

ottokruse avatar ottokruse commented on August 27, 2024

Any update on this issue from 1Password side @charlesjiang-greengate ?

I'm inclined to close the issue here.

from amazon-cognito-passwordless-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.