Comments (8)
Thank you very much looking into this issue. I will try to chase it up on 1Password's end.
from amazon-cognito-passwordless-auth.
Please close this issue. Fault is not with this library here.
1Password has been unresponsive on this issue
from amazon-cognito-passwordless-auth.
Thanks for the report.
This might be better directed at 1Password potentially though?
I don't use 1Password and can't reproduce this but let's try to see if we can locate and fix it with your help.
Question, how did you confgure the lib, what value are you using for debug
?
Illegal invocation
maybe caused by to the destructuring of response
(from credential.response
, maybe 1Password proxies it). Have a try changing our code directly inside your node_modules to:
debug?.("Created credential:", {
credential,
getTransports: credential.response.getTransports?.(), // `credential.response` instead of `response`
getAuthenticatorData: credential.response.getAuthenticatorData?.(), // `credential.response` instead of `response`
getPublicKey: credential.response.getPublicKey?.(), // `credential.response` instead of `response`
getPublicKeyAlgorithm: credential.response.getPublicKeyAlgorithm?.(), // `credential.response` instead of `response`
});
Or it's because debug
doesn't work like that and you need to call configure differently:
Do:
Passwordless.configure({
...,
debug: console.debug.bind(console),
});
Instead of:
Passwordless.configure({
...,
debug: console.debug,
});
(But there's other debug calls that you'd have run into earlier then so I doubt that is the issue.)
from amazon-cognito-passwordless-auth.
Hi @ottokruse , thanks for coming back to you. I think you are correct on this one, that this is likely to be caused by implementation bug with 1Password chrome extension. I will raise this issue with 1Password to see if they can fix it on their end.
debug is currently the default configuration which is debug: console.debug
, I will give your suggestion a try and come back to you on this.
from amazon-cognito-passwordless-auth.
Justing reporting back:
credential.response.getAuthenticatorData()
still returns the same error Uncaught TypeError: Illegal invocation
.
Changing to debug: console.debug.bind(console),
also didn't help.
Using debug console, I can see the following for response
from amazon-cognito-passwordless-auth.
This seems to be an existing issue someone has just raised with 1Password as well.
I am not sure if it is within the spec to be able to call getPublicKey()
etc.
from amazon-cognito-passwordless-auth.
We only call that method if it's not null
or undefined
in which case it should work (as per spec: https://www.w3.org/TR/webauthn-2/#dom-authenticatorattestationresponse-getpublickey)
So yes this looks like an issue for 1Password
from amazon-cognito-passwordless-auth.
Any update on this issue from 1Password side @charlesjiang-greengate ?
I'm inclined to close the issue here.
from amazon-cognito-passwordless-auth.
Related Issues (20)
- Passwordless.configureFromAmplify() no longer works with the latest version of Amplify (v6)
- Type error in Verifying FIDO2 Challenge Response HOT 6
- Usage of stepUpAuthenticationWithSmsOtp in plain web. HOT 5
- Feature request: HOT 1
- Amplify cli end-to-end example HOT 5
- [Question] Using Fido2 credentials for non-signin challenges HOT 1
- Prominently mention JWT/localStorage issues in FAQ -- Avoid JWT? HOT 6
- signInStatus is 'NOT_SIGNED_IN' during refresh of token HOT 3
- Dependency issue while implementing this tutorial HOT 4
- FrontEnd Shows "Unexpected End of JSON Input" HOT 8
- The example don't work corrrectly with Windows Hello through PIN authentication HOT 17
- [Feature] Provide a python package HOT 1
- Resetting state HOT 4
- Magic Link Metadata Storage HOT 8
- ReferenceError: debug is not defined HOT 1
- [Bug] Magic link abuse by authorized user HOT 9
- [Feature Request] Add OTP SMS authentication HOT 5
- Can we load logo from assets folder locally HOT 4
- Prevent users from self-edit attributes HOT 6
- [Need Help] - No "exports" main defined in ../node_modules/amazon-cognito-passwordless-auth/package.json HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-cognito-passwordless-auth.