Comments (4)
willarmiros
commented on August 29, 2024
@NathanielRN is this a regression upstream? Also, any idea why duplicate issues are being created? I thought we made a fix for that but might be misremembering.
from aws-otel-js.
NathanielRN
commented on August 29, 2024
@willarmiros Sorry no this isn't an issue upstream, this was my bad for not updating the benchmark output format when I changed the GH action we use in #71. The step to analyze the performance results AFTER was "failing" but not because of performance results. It was because of an invalid format. I fixed that in #75.
Also, any idea why duplicate issues are being created?
Ah yes I'm fairly certain it's because in #71 I only made the change for issues that are posted for performance issues DURING tests, not AFTER. In #76 I added the missing flag to fix this and prevent it from happening again 🙂 .
from aws-otel-js.
NathanielRN
commented on August 29, 2024
Closed in #75.
from aws-otel-js.
willarmiros
commented on August 29, 2024
Great makes sense, thanks for the patch!
from aws-otel-js.
Related Issues (20)
- Performance Threshold breached AFTER Soak Tests completed for the (http, manual) Sample App HOT 2
- Performance Threshold breached DURING Soak Tests execution for the (http, manual) Sample App HOT 2
- Support for X-Ray remote sampling. HOT 5
- OpenTelemetry Propagator AWS X-Ray does not work with @opentelemetry/core and api >=0.12.x HOT 1
- AWS Resources not recognised (AWS SDK v3 support) HOT 5
- Failed to load gRPC binary module because it was not installed for the current system HOT 7
- Trace state not set in AWSXRayPropagator HOT 5
- Http status code is always 0 in X-ray for JS otel instrumentation HOT 3
- AWSXRayIdGenerator vs AwsXRayIdGenerator HOT 2
- "@opentelemetry/api" should be a peer dependency for Xray Propagator HOT 4
- TypeError: api_1.getSpan is not a function HOT 3
- Sample App Not Emitting Metrics HOT 1
- Performance Threshold breached AFTER Soak Tests completed for the (http, manual) Sample App HOT 1
- Performance Threshold breached AFTER Soak Tests completed for the (http, manual) Sample App HOT 1
- metrics HOT 4
- Modified sample app http call to use https scheme HOT 2
- Usage of @opentelemetry/resource-detector-aws HOT 2
- Using Xray Id generator does not work HOT 4
- JavaScript sample app and documentation updated for metrics GA HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-otel-js.