Giter Club home page Giter Club logo

Comments (8)

michaeltorbert avatar michaeltorbert commented on July 28, 2024

Classes should be accepted as a possible array (required) Should be notice plus any one of notice-error, notice-warning, notice-success, or notice-info. Optionally use is-dismissible to apply a closing icon.

from all-in-one-seo-pack.

michaeltorbert avatar michaeltorbert commented on July 28, 2024

Related to #25

from all-in-one-seo-pack.

michaeltorbert avatar michaeltorbert commented on July 28, 2024

check out github.com/collizo4sky/persist-admin-notices-dismissal

from all-in-one-seo-pack.

michaeltorbert avatar michaeltorbert commented on July 28, 2024

We also need to make sure we support <4.2 (which may have been the problem with our prior woocommerce notices not dismissing)

from all-in-one-seo-pack.

EkoJR avatar EkoJR commented on July 28, 2024

@michaeltorbert I noticed this issue similar to 'Add a 5 star ratings request' #61, and wanted to request assigning this.

I am aware of most of the notices by now, and took a look at the Repo for Persistant Admin Notice Dismissal. The other repo seems to apply a similar concept by working off a time-lapse, and uses a dismissal variable. Then saves it as wp_options. Not too much different than what is already in development.

One other thought that did occur to me though, is...

  • Making the dismissal unique to users. So, multiple Admins users can dismiss the notice without it dismissing for others that would otherwise act on the notice.

from all-in-one-seo-pack.

michaeltorbert avatar michaeltorbert commented on July 28, 2024

@EkoJR I've assigned this two you, but we should be careful about possible conflicts. It's probably best to wait until the other one is finished before doing this.

Offhand I'd say some notice dismissals may be unique to users, but most are probably site wide.

Something a bit different but a similar subject: #998

from all-in-one-seo-pack.

EkoJR avatar EkoJR commented on July 28, 2024

Understood. I was curious if I should wait for the other branch.

from all-in-one-seo-pack.

wpsmort avatar wpsmort commented on July 28, 2024

Issue moved to awesomemotive/aioseop-pro #774 via ZenHub

from all-in-one-seo-pack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.