Giter Club home page Giter Club logo

Comments (2)

oyeb avatar oyeb commented on June 5, 2024

Though a default currency is required by all gateways, IMO it is unlikely that it will be same across all gateways:

  • Large multi-national merchants might use multiple gateways because some gateways offer better/cheaper service in some regions, but not in others. In that case, each of these gateways would be configured for a different currency.
  • All gateways should set a default currency (since this is truly very specific to a gateway and not merchant dependent), but where? We could do something like this or add it in the required_config for all gateways.

from gringotts.

pkrawat1 avatar pkrawat1 commented on June 5, 2024

After the introduction of #62 and merges in #71 #85 it becomes evident that the lib users can use money lib to create money object.

Responsibility of creating a correct money struct lies on the developer and follows the rules and constraints of money ex_money lib.

Hence, having default_currency in the global config does not make much sense now.

from gringotts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.