Giter Club home page Giter Club logo

Comments (8)

jordibruin avatar jordibruin commented on August 31, 2024 2

Don't get me wrong, I appreciate the feedback! Just trying to explain the rationale behind some choices, but maybe I came across defensive, sorry!

Would love to see a PR that tackles this. Maybe you can rename this issue to something like "Make more flexible" so that we can use this issue to discuss what kind of things would be useful to expose!

from roadmap.

shaps80 avatar shaps80 commented on August 31, 2024 1

To be honest if I wanted to implement something like this in my apps (especially for a client), I'd need the design to 'fit' – basic styling changes generally won't be enough I'd argue in most cases, but lets say at least some.

Its totally fine btw if you want to disregard my ideas I'm not attached to them lol.

Its a great idea and you've executed nicely overall 👍 Just thought I'd add to the mix in case its helpful, keep up the great work, sorry for complicating it haha 👍

If you're open to PRs and I have some spare time I'd be happy to make a PR that suggests the changes – maybe that clarifies better, and if not you can always reject/close it 👍

Also, feel free to close this comment – I don't want to clutter up your Issues

from roadmap.

shaps80 avatar shaps80 commented on August 31, 2024 1

No I didn't get that feeling at all, all good 👍 – Textual conversation is much hard right? Haha.

I'll rename for you, thanks.

from roadmap.

jordibruin avatar jordibruin commented on August 31, 2024

Good feedback. We wanted to create the simplest implementation that someone could add in 2 minutes with a very clear purpose and usecase.

If we would make it more low level there would not be a very straight forward path for someone to add this without a lot of their own work correct?

Can you explain what options don't scale with the current method?

from roadmap.

shaps80 avatar shaps80 commented on August 31, 2024

You could keep the current implementation as a higher level abstraction – cause I get the use case and I agree its a great idea 👏

As to my other comments, I just mean if you check your Issues you can see already that most if not all request are for more customisation, that's difficult to keep adding to, since it quickly goes beyond any reasonable scope without being extremely project specific.

Screenshot 2023-02-21 at 12 24 55

from roadmap.

shaps80 avatar shaps80 commented on August 31, 2024

Again, I love the idea and simplicity of this, I was just suggesting that exposing relevant API that's not bound to the UI, enables more custom implementations to exist while still benefiting from your original conception, which is great.

But again, you can have the best of both worlds 👍 and better yet, your UI bits would benefit from the same APIs.

from roadmap.

jordibruin avatar jordibruin commented on August 31, 2024

@shaps80 I made (or brought them up in our chat) most of the issues that you highlighted, and we plan to add all of them within the current implementation.

I think we don't want to create a solution that handles each edge case, so we'll definitely have to make choices here and there to not overcomplicate things.

That being said, we made this over the last 2.5 days, so we also just wanted to keep it simple and launch so we could get feedback. Would be curious to hear what features you would want to add that aren't possible with the default approach.

from roadmap.

jordibruin avatar jordibruin commented on August 31, 2024

@shaps80 have a look at this 👀

Would love your feedback!

#38

from roadmap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.