Giter Club home page Giter Club logo

Comments (4)

github-actions avatar github-actions commented on July 17, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • pau2Xa-5Sh-p2#comment-15397

from wp-calypso.

aneeshd16 avatar aneeshd16 commented on July 17, 2024

Since the first feature is the domain and the old copy doesn't show anything when there is no paid domain picked, we need to fill that blank somehow, e.g. showing "WordPress.com subdomain"

"WordPress.com subdomain" is not a part of the old copy, so the structure-only variant won't be a strictly structure-only change and could influence the experiment.

Sort the feature list for the structure-only variant without affecting the order of the control variation.
Bring back the payment commission fee feature like control does, and place it accordingly.

For both of the above, I think we'll have to add the full feature list in plans-list.tsx for the structure-only variant. Otherwise, the grid would show the commission fees for previous plans as well:
image

It would also mean that the includePreviousPlanFeatures prop will no longer be required.

from wp-calypso.

aneeshd16 avatar aneeshd16 commented on July 17, 2024

I have a fix ready in #90484, but it does not address the alignment issues for the "Free domain" feature and the "Growth and monetization tools" section.

from wp-calypso.

southp avatar southp commented on July 17, 2024

I think #90484 is a practical enough fix for the experiment purpose, so I'm closing this.

from wp-calypso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.