Comments (1)
I submitted a PR, a few notes:
-
I renamed the classes and files too
-
Due to changes to the options key change - if someone is using
ramp_for_gutenberg()
function currently - they'll have to do two reloads for the settings to catch up.
To avoid two reloads, we could do something like this on VIP Go helper file, but this seems like overkill:
function gutenberg_ramp_migrate() {
$old_criteria = get_option( 'ramp_for_gutenberg_load_critera' );
// Fail fast if there is no old criteria
if ( false === $old_criteria ) {
return false;
}
$new_criteria = get_option( 'gutenberg_ramp_load_critera' );
// Cancel if there is already new criteria
if ( ! empty( $new_criteria ) ) {
return false;
}
// --- at this point $new_criteria doesn't exist, and $old_criteria has been defined
// Update new option
update_option( 'gutenberg_ramp_load_critera', $old_criteria );
// Delete the old option
delete_option( 'ramp_for_gutenberg_load_critera' );
}
// Ready, Set, Migrate:
// This would run before anything else related to Gutenberg Ramp
// For example
gutenberg_ramp_migrate();
^^-- If that snippet is used, we need to make sure it's loaded before anything else related to Gutenberg Ramp. This seems like a good place to do so.
- How will VIP Go MU plugins handle the rename on GitHub?: https://github.com/Automattic/vip-go-mu-plugins
from gutenberg-ramp.
Related Issues (20)
- In settings, improve checkbox UI for enabling custom post types HOT 6
- Cross linking an issue in regards to additional editing options HOT 1
- Suggested enhancements - to plugin or to documentation HOT 4
- generalize criteria for GB loading HOT 8
- Disable 'try Gutenberg' banner in wp 4.9.8, if using Ramp HOT 7
- Admin Alert when Gutenberg is off - dismissible forever HOT 1
- Autoloading ramp options HOT 3
- Does not support 'fallback' mode HOT 2
- allow opt-in to Gutenberg by post/page slug or tag HOT 2
- Bug: Gist embedding not displaying in editor HOT 1
- wpcom_vip_load_gutenberg doesn't allow meta boxes to be loaded HOT 3
- Disable Ramp when Gutenberg version requirements aren't met HOT 3
- All options in the UI should be greyed out in the cases where Ramp sets Gutenberg to always or never load
- Make Ramp + Classic Editor play nicer together HOT 2
- Make it clearer how to enable Gutenberg for all post types HOT 1
- Add some clarity to the documentation about Gutenberg requirement HOT 1
- "Greater Than" HOT 4
- Ability to modify admin screen access
- The UI isn't displaying at all. HOT 1
- Plugin always loads classic-editor when classic-editor plugin is installed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg-ramp.