Comments (5)
I've gone for a simple plain text version in #46 which replaces the content in the email with a nicer plain text version.
from blocks-everywhere.
The redesigned notification emails on WP.com support forums support block content. However, in bbPress core, there's a heavy HTML stripping with strip_tags
. Basically, core bbPress emails are text only. We don't have that in the redesigned notifications emails. However, not sure what is the best course of action for bbPress core here. Push the fully redesigned notification emails to core? Probably, so that the blocks look good in the emails. But community might not like that. Or just remove the strip_tags
call?
If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.
cc @lezama
from blocks-everywhere.
If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.
I think we should do this and add filters to separate WPCOM only logic.
from blocks-everywhere.
I would personally suggest taking the almost do-nothing approach for bbPress emails.
Ensure that the plain-text generated is good-enough, while not going above-and-beyond.
That could just mean stripping Block HTML out before bbPress strips it, so bbPress gets a "clean" text, and potentially doing some nice things like decoding code blocks and adding bullet points for lists.
from blocks-everywhere.
Closing this as done.
from blocks-everywhere.
Related Issues (20)
- URLs within code blocks should not oEmbed HOT 2
- Pass form or post/comment details through the editor
- Hide comment textarea in bp activity HOT 1
- BP activity comment area missing placeholder and aria-label
- Automated Testing
- Possible to add to selected textareas? HOT 1
- Doesn't work with the standalone Gutenberg Plugin activated. HOT 3
- Twentytwenty-three: unable to click on header links
- Fix for Gutenberg 15.7.0
- enabling image upload HOT 3
- Add new link button hidden on hover HOT 1
- bbp_get_topic_id function not exist
- Compatibility issue with 1.21.0 and Gutenberg 16.9 HOT 5
- __experimentalGroup will be removed
- Accessibility issue on `components-dropdown-menu__toggle` button inside support forum customised editor HOT 1
- Twenty Twenty-Four theme, usntable API warning ? HOT 1
- Gutenberg 17.8 support HOT 1
- Color confilct with code block on new WP forum design HOT 1
- The icons on the link toolbar popup appear too small.
- Widths set on Blocks Everywhere in Forums breaks layout
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blocks-everywhere.