Giter Club home page Giter Club logo

Comments (5)

johngodley avatar johngodley commented on August 22, 2024 1

I've gone for a simple plain text version in #46 which replaces the content in the email with a nicer plain text version.

from blocks-everywhere.

lamosty avatar lamosty commented on August 22, 2024

The redesigned notification emails on WP.com support forums support block content. However, in bbPress core, there's a heavy HTML stripping with strip_tags. Basically, core bbPress emails are text only. We don't have that in the redesigned notifications emails. However, not sure what is the best course of action for bbPress core here. Push the fully redesigned notification emails to core? Probably, so that the blocks look good in the emails. But community might not like that. Or just remove the strip_tags call?

If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.

cc @lezama

from blocks-everywhere.

lezama avatar lezama commented on August 22, 2024

If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.

I think we should do this and add filters to separate WPCOM only logic.

from blocks-everywhere.

dd32 avatar dd32 commented on August 22, 2024

I would personally suggest taking the almost do-nothing approach for bbPress emails.

Ensure that the plain-text generated is good-enough, while not going above-and-beyond.

That could just mean stripping Block HTML out before bbPress strips it, so bbPress gets a "clean" text, and potentially doing some nice things like decoding code blocks and adding bullet points for lists.

from blocks-everywhere.

johngodley avatar johngodley commented on August 22, 2024

Closing this as done.

from blocks-everywhere.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.