Giter Club home page Giter Club logo

Comments (3)

ianstewart avatar ianstewart commented on June 26, 2024

Since _s is by Auttomatic and suppose to be the ideal coding standards for WordPress having 0 recommendations would is probably desired.

A couple of these recommendations are already taken care of in the theme -- Theme Check is finding the back compat for the old custom header image API for example. As for some of the others -- they would probably bloat _s. Some are not really necessary for every theme (editor styles, for example). Which is closer to the goal that _s is trying to hit. Not trying to cover every edge case, but the most number of common cases for the most number of people.

from _s.

kovshenin avatar kovshenin commented on June 26, 2024

RECOMMENDED: get_current_theme found in the file inc/theme-options/theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.

_s uses wp_get_theme, but falls back to get_current_theme for when the former is not available. This makes _s compatible with older versions of WordPress. I'm not really sure if there's a neat way to get rid of a notice like that without changing the Theme Check plugin, but I'm sure the .org review team understands that.

from _s.

TechRemarker avatar TechRemarker commented on June 26, 2024

Great thanks guys, glad to knows its more issues with the plugin flagging backwards compatibility rather than the theme itself. Thanks!

from _s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.