Comments (8)
@wasabii Yes, making the module internal was intentional.
Do you have an exception that you can provide or a quick reproduction? I don't think RegisterAssemblyModules
includes internal
types by default.
from autofac.servicefabric.
It looks like internal types are considered. I guess what makes this different from regular cases is the non-default constructor. This is actually an issue for the core library more than this integration. I might open a separate issue in core for this.
from autofac.servicefabric.
Be careful if you change this in the core - had a similar issue about assembly type scanning and people have come to rely on the behavior, considering it a breaking change when I tried to make it public-only by default.
from autofac.servicefabric.
I was just about to link that that very issue.
from autofac.servicefabric.
It is actually the internal
constructor that is causing the problem in this case. The internal
class is located in RegisterAssemblyTypes
but the instance cannot be created because the DefaultConstructorFinder
excludes the internal
constructor.
From a backwards compatibility perspective changing anything in core around this will be difficult, especially since it sits on top of something that we have already decided is hard to change. A similar "public only" option is something that could be considered.
I would certainly recommend when assembly scanning to try and reduce what you include. Using a base type for your modules is a reasonable choice. I'll have a think about what else we might be able to do.
from autofac.servicefabric.
Internal type, public constructor?
from autofac.servicefabric.
That does prevent the exception but still includes the module in the scan. I actually added code in the RegisterServiceFabricSupport
method to prevent the registrations in the module from being added twice. It might not matter that much, but it does highlight an issue with overreach in the module registration path.
from autofac.servicefabric.
I think I'll just convert the module code into a static helper method removing the module from the picture all together.
from autofac.servicefabric.
Related Issues (20)
- InstancePerMatchingLifetimeScope HOT 2
- Reduced extensibility due to access restrictions in classes and methods HOT 3
- Allow logging exceptions during service instantiation HOT 8
- Access denied in RegisterActor HOT 5
- How to communicate to stateful service use remoting? HOT 2
- How to inject custom ActorService HOT 2
- How to use Serilog, Autofac and Service Fabric Actors together HOT 3
- Dynamic Proxy breaks optional constructor arguments
- Cannot create Stateless Service in Service Fabric injecting my own objects in HOT 2
- Service class constructor never invoked
- Lifetime scope for Actor instance HOT 2
- Not support 6.3.187 HOT 1
- Allow use of current ILifetimeScope in the exception callback HOT 1
- Message "Access is denied
- Cannot resolve parameter 'System.Fabric.StatefulServiceContext serviceContext' HOT 2
- Singleton does not play nicely with ServiceContext dependency HOT 1
- MissingMethodException after update to Autofac 5.0.0 HOT 1
- Compatibility with Autofac v6 HOT 1
- Allow injecting additional registrations during the creation of service lifetimescope HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autofac.servicefabric.