Comments (3)
Are you running into an issue where changing the current mechanism is required? I'm open to change if there's a reason, but it needs to be something quantifiable like a consistent perf improvement (ie not just an improvement during tenant registration, which is a relatively uncommon path).
from autofac.multitenant.
That's a good point. I was thinking in terms of refactoring as part of expanding the current interaction points with the tenant dictionary, partly in response to #5 . Really I just wanted to make sure that it wasn't precluded somehow.
I thought I recalled some debate about this, or maybe about locking in general. I saw the issue reference in https://github.com/autofac/Autofac.Multitenant/blob/develop/src/Autofac.Multitenant/MultitenantContainer.cs, but couldn't track it down (dates back to Google Code, I'm guessing?).
Sounds like the only issue is avoiding premature/unnecessary optimization. If so, please close this issue. Thanks!
from autofac.multitenant.
I think it might be premature optimization. Since configuring (or reconfiguring) tenants shouldn't be something that happens, say, on a per-request basis in a web app or something, it all should be in an uncommon path where a difference of a few ms doesn't make or break the app. However, when we get to addressing the reconfiguration of tenants, we'll keep in mind potentially updating locks to be different if needed. I'll make a note in that issue so we don't forget. Thanks!
from autofac.multitenant.
Related Issues (17)
- Allow tenant dependencies to be explicitly resolved HOT 1
- Multi-tenant for IEnmerable service
- InstancePerTenant dependency and tenants reconfiguration HOT 2
- Set the active tenant on a resolved child scope? HOT 1
- Integration not compatible with Autofac 5.0 Release Candidate
- Invalid interaction between DisposeAsync and Dispose in MultitenantContainer HOT 1
- vNext HOT 1
- Compatibility with Autofac v6 HOT 1
- Support for configuring multi-tenant types via configuration file HOT 3
- Upgrade Autofac Multitenant with Asp.Net Core 2.2 to Asp.Net 5 HOT 1
- Add virtual keyword to MultitenantContainer.ConfigureTenant HOT 4
- Autofac 7.0 breaks multitenant support HOT 2
- Autofac Multitenancy does not add tenant configuration when using new JSON config HOT 2
- Reconfiguration of tenants in MultitenantContainer HOT 2
- Upgrade to VS 2017 HOT 1
- Getting all registered tenants Ids and clearing registrations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autofac.multitenant.