api requests can exceed client_body_buffer_size, which makes the hooks fail about lua-resty-auto-ssl HOT 4 CLOSED

Interesting, I wonder why sometimes the request size is bigger (I don't think I've run into this personally), but definitely good to know about.

I can incorporate this into the suggested configuration in the README, and also see if there's maybe a way for us to check this on startup and warn users if their configuration needs to be updated.

Thanks again!

from lua-resty-auto-ssl.

We should be able to catch the error when we call get_post_args(). That's not at startup, but at least it gives some kind of message to the user.

We do not know beforehand how big the requests will be. This means, we can only print a generic warning on startup, when client_body_buffer_size is set to or near the default value. Buuut that value can of course be different for every server or even location, so we'd have to find the right one for our internal server first. Hm.

Unless you know some clever way to get the config, I'd vote for just noting this in the README as well as in the example configuration.

from lua-resty-auto-ssl.

I updated the documentation (#77), and made this part of the recommended v0.11.0 upgrade. Thanks for reporting this!

from lua-resty-auto-ssl.

Looks nice. Thank you! This should make the API server more robust 👍

from lua-resty-auto-ssl.