Giter Club home page Giter Club logo

Comments (6)

jfromaniello avatar jfromaniello commented on July 28, 2024

Yes, it make sense @hzalaz will look into this.. thank for all your feedback

from ruby-auth0.

dentarg avatar dentarg commented on July 28, 2024

@hzalaz I noticed 6e19b8f

When 2 builds run in parallel, they clash with each other.

I think the answer is https://github.com/vcr/vcr

GitHub uses it for their API client, you can read about it at https://github.com/octokit/octokit.rb#running-and-writing-new-tests

from ruby-auth0.

dentarg avatar dentarg commented on July 28, 2024

I think the answer is https://github.com/vcr/vcr

...not to remove number of Ruby versions to test against

from ruby-auth0.

hzalaz avatar hzalaz commented on July 28, 2024

I know about vcr but in my experience the recorded tests will get outdated easily and everything will seem ok when it shouldn't, that's the reason I'd rather hit the API directly for integration tests. Also we're already mocking http in unit tests (I'd rather use them there) so both test will be exactly the same.

I want to rework the "new tests" to avoid clashing with each other (like prefixing ids) but until then I prefer a reliable build.

from ruby-auth0.

dentarg avatar dentarg commented on July 28, 2024

I understand. Nice work on this!

from ruby-auth0.

hzalaz avatar hzalaz commented on July 28, 2024

We don't have all endpoints tested against the real API but at least we have most of /users which should be the most used. We'll continue to add more endpoints eventually. PR are welcome! 😄

from ruby-auth0.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.