Comments (3)
Hi Darrell. Thanks for this report and the PR. I've mixed feelings about us putting a specific ServicePointManager.SecurityProtocol
in the samples, as I believe it is too opinionated. Some examples:
- in version 4.7 of the framework the recommended value is
SecurityProtocolType.SystemDefault
which will give you the best option available in the operating system where the app is running. - forcing TLS 1.2 might break development on older servers if they are not properly configured.
- the setting affects the whole application, not just the OpenIDConnect middleware.
The subject is fairly complex (see https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls for details). For people targetting the 4.5.2 version of the framework Microsoft recommends upgrading to 4.7. Read on for a couple of recommendations if that's not possible, but manually setting a ServicePointManager.SecurityProtocol
does not seem to be the recommended path.
It seems that, from a best practices point of view, we should upgrade our samples to 4.7 instead (which is always a tricky decision because compatibility with older systems might be affected).
from auth0-aspnet-owin-mvc-samples.
Agreed letting the operating system decide, or using system default would be the best option. The PR was intended as a quick fix as we are dealing with multiple teams that are using your samples and this has become a support issue for us. A lot of the systems we write and integrate with mandate TLS 1.2 support. As such, I suspect this will be reported by others if the samples are left targeting aging netfx.
from auth0-aspnet-owin-mvc-samples.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇♂️
from auth0-aspnet-owin-mvc-samples.
Related Issues (20)
- Missing code on Sample
- There are no instructions to execute the sample HOT 2
- client.GetTokenAsync returns exception HOT 7
- ASP.NET (OWIN) Regular Web App: Signature validation error when login in or signing up HOT 4
- no readme's
- I encountered "Error occurred during a cryptographic operation" when trying MvcApplication sample HOT 1
- ASP.NET 4 Support
- Where is "callback"? HOT 7
- Add example for obtaining access token HOT 2
- Logout adress generated by notification.ProtocolMessage.PostLogoutRedirectUri has stacked protocols HOT 4
- Error with default configuration HOT 1
- Running the application HOT 2
- The session cookie is sometimes not set properly
- Duplicated code in Startup.cs? HOT 1
- Role Authorization not working? HOT 1
- outdated dependencies
- missing instruction in readme.md HOT 1
- Set up the Kentor.OwinCookieSaver package in the samples and seeds HOT 1
- no audience parameter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auth0-aspnet-owin-mvc-samples.