Giter Club home page Giter Club logo

Comments (3)

nicosabena avatar nicosabena commented on August 18, 2024

Hi Darrell. Thanks for this report and the PR. I've mixed feelings about us putting a specific ServicePointManager.SecurityProtocol in the samples, as I believe it is too opinionated. Some examples:

  • in version 4.7 of the framework the recommended value is SecurityProtocolType.SystemDefault which will give you the best option available in the operating system where the app is running.
  • forcing TLS 1.2 might break development on older servers if they are not properly configured.
  • the setting affects the whole application, not just the OpenIDConnect middleware.

The subject is fairly complex (see https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls for details). For people targetting the 4.5.2 version of the framework Microsoft recommends upgrading to 4.7. Read on for a couple of recommendations if that's not possible, but manually setting a ServicePointManager.SecurityProtocol does not seem to be the recommended path.

It seems that, from a best practices point of view, we should upgrade our samples to 4.7 instead (which is always a tricky decision because compatibility with older systems might be affected).

from auth0-aspnet-owin-mvc-samples.

dmarjoram avatar dmarjoram commented on August 18, 2024

Agreed letting the operating system decide, or using system default would be the best option. The PR was intended as a quick fix as we are dealing with multiple teams that are using your samples and this has become a support issue for us. A lot of the systems we write and integrate with mandate TLS 1.2 support. As such, I suspect this will be reported by others if the samples are left targeting aging netfx.

from auth0-aspnet-owin-mvc-samples.

stale avatar stale commented on August 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

from auth0-aspnet-owin-mvc-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.