Comments (11)
EisenbergEffect
commented on July 28, 2024
1
Closing this since jsdom merged an SVG implementation.
from pal-nodejs.
EisenbergEffect
commented on July 28, 2024
Can you submit a PR with your recommendation?
from pal-nodejs.
niieani
commented on July 28, 2024
Yeah, I'll try. Maybe we can make a simple implementation like in this article: https://www.smashingmagazine.com/2014/05/love-generating-svg-javascript-move-to-server/#jsdom
It won't be complete, but it will be better than nothing.
from pal-nodejs.
EisenbergEffect
commented on July 28, 2024
Sure. It can be added to pal-nodejs.
from pal-nodejs.
niieani
commented on July 28, 2024
Actually, I see there's a PR with (incomplete) SVGElement support sitting in the JSDOM repo since April.
As long as we're going with our own fork of JSDOM anyway, we could probably merge that, or maybe even complete the implementation, if its not too much work and send a new PR to the maintainers.
from pal-nodejs.
EisenbergEffect
commented on July 28, 2024
It's worth looking into.
from pal-nodejs.
niieani
commented on July 28, 2024
Temporary remedy for getting server-side stuff to load, but not a real fix: #18
from pal-nodejs.
niieani
commented on July 28, 2024
I'm gonna reopen and rename this issue, since we don't have a proper fix yet.
from pal-nodejs.
Alexander-Taran
commented on July 28, 2024
May be relevant: A Better SVG implementation jsdom/jsdom#2011, which is merged novemer 11, before ~11.5 version lock for jsdom for pal-nodejs
from pal-nodejs.
Alexander-Taran
commented on July 28, 2024
@niieani can you check jsdom update?
from pal-nodejs.
niieani
commented on July 28, 2024
I believe @MeirionHughes might have better context for this.
from pal-nodejs.
Related Issues (14)
- Implement HOT 20
- Integration Testing HOT 11
- nodejs process doesn't terminate
- Support ShadowDOM HOT 1
- Trigger Mutation Search only on change.
- Basic usage HOT 2
- JSDOM private _core api is not available anymore HOT 12
- NodeList not available in context of testing with Jest HOT 2
- Refreshing current page after initial load returns an Internal Server Error HOT 3
- Security issue in jsdom dependency HOT 3
- Not writable "undefined" property with jsdom 19 HOT 2
- 🙏 Update dependencies and release the version HOT 1
- Enable GitHub Testing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pal-nodejs.