Issue with aurelia/binding typings about binding HOT 12 CLOSED

I think that d359e83 might have broken this. For example, with aurelia-binding 2.2.0 I can import the disableConnectQueue function from aurelia-binding, but with 2.2.1 I cannot, even though it's available at runtime. This seems like a regression.

from binding.

@dhanapalschandran Thanks for filing this. Can you help paste the full error message? It seems important parts of the error were not captured.

from binding.

@dhanapalschandran Thanks for filing this. Can you help paste the full error message? It seems important parts of the error were not captured.

Hi @bigopon , I have provided the screenshot of the error we got during gulp build, Thanks.

from binding.

@dhanapalschandran I see the updated picture. I'm curious about your usage, as it seems you are importing bindingMode from aurelia-templating?
As far as I know, it should have never worked because it's the import from aurelia-binding. The only module that reexport bindingMode is aurelia-framework, which means:

// not working
- import { bindingMode } from 'aurelia-templating';
// working
+ import { bindingMode } from 'aurelia-framework';

from binding.

@dhanapalschandran I see the updated picture. I'm curious about your usage, as it seems you are importing bindingMode from aurelia-templating?
As far as I know, it should have never worked because it's the import from aurelia-binding. The only module that reexport bindingMode is aurelia-framework, which means:

// not working
- import { bindingMode } from 'aurelia-templating';
// working
+ import { bindingMode } from 'aurelia-framework';

Yes correct, this was error was popped from aurelia-templating index.d.ts, when i change the aurelia-binding version to 2.1.7, the error disappears

from binding.

@dhanapalschandran If possible, can you help do a clean install of project dependencies to see if anything interesting happens? It shouldn't matter, but since we've had issues related to it before, a try may not hurt.

@josiahhaswell Can you help confirm if this is the same issue you mentioned on Gitter?

from binding.

@dhanapalschandran Also can I know your typescript version?

from binding.

@dhanapalschandran If possible, can you help do a clean install of project dependencies to see if anything interesting happens? It shouldn't matter, but since we've had issues related to it before, a try may not hurt.

@josiahhaswell Can you help confirm if this is the same issue you mentioned on Gitter?

Hi @bigopon , I have done clean install several times before posting the issue

from binding.

@dhanapalschandran Also can I know your typescript version?

"typescript": "^2.8.1",

from binding.

@dhanapalschandran Are you somehow directly installing from the master branch? We are moving towards a new, more streamlined workflow with CircleCI but it seems the build process is not entirely correct yet. The dist files do seem to be missing stuff. Will fix this asap

from binding.

@jmezach nice, thanks for the catch. The issue comes from the fact that typings was commited to dist file in this f4012aa while it should have been committed to typings file in src. I'll fix that soon.

from binding.

All issues have been fixed after #746 .
It can be closed @EisenbergEffect @dhanapalschandran

from binding.