Continuation of the Numeric Keys for Options issue about aura.html HOT 7 CLOSED

Hi @bsahlhof sorry to take so long to get back to you. Which Select issue was this, so I can look it up and apply a similar fix?

from aura.html.

Do you mean https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/Radio.php#L51-L59, perhaps? If that's the case, it's not necessarily wise to assume that an integer $value should use $label as the value instead, because it might be that the value is supposed to be an integer.

If that's not the case, let me know.

from aura.html.

I'll review when I'm near my development pc, but the issue was that when
the key of the options were integers (Which converted to the value, not the
label), when the check was made, it would always come back false...
specifically because of these lines:
https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/AbstractChecked.php#L68-L81

I have not checked this functionality for quite some time, but assuming the
issue wasn't previously fixed, then the strict === causes this statement to
always be false if integers (or, I believe string numbers) were used within
the array passed in. ( 1 !== '1' )

On Mon, Mar 16, 2015 at 12:12 PM, Paul M. Jones [email protected]
wrote:

Do you mean
https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/Radio.php#L51-L59,
perhaps? If that's the case, it's not necessarily wise to assume that an
integer $value should use $label as the value instead, because it might
be that the value is supposed to be an integer.

If that's not the case, let me know.

—
Reply to this email directly or view it on GitHub
#21 (comment).

from aura.html.

Ah so! In Select, we solved it with a $strict property that could be turned off and on. I'll try that here too.

from aura.html.

@pmjones no tests ;) .

from aura.html.

Good grief @harikt give it five minutes. ;-)

from aura.html.

:) . noticed .

from aura.html.