Comments (7)
Hi @bsahlhof sorry to take so long to get back to you. Which Select issue was this, so I can look it up and apply a similar fix?
from aura.html.
Do you mean https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/Radio.php#L51-L59, perhaps? If that's the case, it's not necessarily wise to assume that an integer $value
should use $label
as the value instead, because it might be that the value is supposed to be an integer.
If that's not the case, let me know.
from aura.html.
I'll review when I'm near my development pc, but the issue was that when
the key of the options were integers (Which converted to the value, not the
label), when the check was made, it would always come back false...
specifically because of these lines:
https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/AbstractChecked.php#L68-L81
I have not checked this functionality for quite some time, but assuming the
issue wasn't previously fixed, then the strict === causes this statement to
always be false if integers (or, I believe string numbers) were used within
the array passed in. ( 1 !== '1' )
On Mon, Mar 16, 2015 at 12:12 PM, Paul M. Jones [email protected]
wrote:
Do you mean
https://github.com/auraphp/Aura.Html/blob/develop-2/src/Helper/Input/Radio.php#L51-L59,
perhaps? If that's the case, it's not necessarily wise to assume that an
integer $value should use $label as the value instead, because it might
be that the value is supposed to be an integer.If that's not the case, let me know.
—
Reply to this email directly or view it on GitHub
#21 (comment).
from aura.html.
Ah so! In Select, we solved it with a $strict
property that could be turned off and on. I'll try that here too.
from aura.html.
@pmjones no tests ;) .
from aura.html.
Good grief @harikt give it five minutes. ;-)
from aura.html.
:) . noticed .
from aura.html.
Related Issues (12)
- Way to make the with out HOT 1
- Calling helpers inside helpers HOT 2
- Better frontend integration HOT 5
- About the new unit and integration testing HOT 1
- Thoughts on supporting the "double_encode" flag? HOT 2
- Assign authority to @jakejohns HOT 11
- JsEscaper duplicating json_encode() ? HOT 10
- Released 2.5.0! HOT 1
- Would like to have PHPdoc on HelperLocator for IDE HOT 2
- PHP 8.1: ctype_digit(): Argument of type int will be interpreted as string in the future HOT 1
- Issue then using numeric key for options HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aura.html.