Giter Club home page Giter Club logo

Comments (10)

csandman avatar csandman commented on June 4, 2024 1

I actually came here to post the same issue, and oddly enough, that's my StackExchange post you linked to @Erudition haha.

But yeah, in FFmpeg version 4.1 they added native support for copying album artwork when decrypting AAX files, so the request is to change the command run by ffmpeg.wasm in the browser to allow this. In order to do it you just have to remove the -vn flag and change -codec:a copy to -c copy.

As far as the other flags like map_metadata and id3v2_version, I'm not sure if you need those, but I've never really needed them when running this conversion process locally.

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

Could you please elaborate your request?

from audible-tools.github.io.

Erudition avatar Erudition commented on June 4, 2024

I'm not sure what more there is to say, I fit it all in the title.
It's more of a suggestion than a request. To rephrase:
The current version of this tool spits out a long ffmpeg command like
ffmpeg.exe -y -activation_bytes 00000000 -i ".\input.aax" -map_metadata 0 -id3v2_version 3 -codec:a copy -vn "output.m4b"
But now, as briefly described in the QA linked, for modern ffmpeg it can simply be
ffmpeg -activation_bytes 00000000 -i input.aax -c copy output.m4b
which has the additional benefit of preserving cover art.

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

@Erudition @csandman PR's welcome

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

@csandman Online conversion is broken with your patch

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

@csandman Fixed it for you.9af760f

from audible-tools.github.io.

csandman avatar csandman commented on June 4, 2024

Awesome! Sorry it didn't work in browser, I could not for the life of me get ffmpeg.wasm to work in the browser, even before I changed anything. I'm glad you got it worked out.

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

I guess you missed the cors headers required for sharedarraybuffers

from audible-tools.github.io.

csandman avatar csandman commented on June 4, 2024

how do you set that up locally? does it not run out of the box?

from audible-tools.github.io.

JKamsker avatar JKamsker commented on June 4, 2024

@csandman
ffmpegwasm/react-app@248e707

from audible-tools.github.io.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.