Comments (9)
RJVB
commented on May 18, 2024
On Saturday November 09 2019 15:41:25 Mojca Miklavec wrote:
Even if the CMake support gets added, the problem will not simply disappear as CMake would call the compiler based on file ending as well.
It will however be easier with CMake to add file-specific compiler arguments.
A slightly related problem is the following piece of code blindly assuming that everyone using VST must be using GTK. We work around it by replacing `VSTControlGTK.cpp` with `VSTControlOSX.mm`, but this needs some conditional on WXMAC as well.
Conditionals are easy with CMake too.
A related, future problem which could be taken into account: wxQt is being rebooted and starting to get somewhere, esp. on MS Windows from what I can see. It definitely has the advantage of hiding a lot more platform-specific issues. At the moment Audacity doesn't support this wx variant at all but it would probably be a good idea to keep its existence in mind when overhauling code that juggles different wx variants (and the build system).
from audacity.
Paul-Licameli
commented on May 18, 2024
It would be most pleasing to segregate all mac-specific Objective-C++ into
.mm files not included in the Windows and Linux builds. It would be a
pleasing separation.
I won't have time to consider the details of that until later this week.
PRL
On Sun, Nov 10, 2019 at 4:13 AM René Bertin <[email protected]>
wrote:
… On Saturday November 09 2019 15:41:25 Mojca Miklavec wrote:
>Even if the CMake support gets added, the problem will not simply
disappear as CMake would call the compiler based on file ending as well.
It will however be easier with CMake to add file-specific compiler
arguments.
>A slightly related problem is the following piece of code blindly
assuming that everyone using VST must be using GTK. We work around it by
replacing `VSTControlGTK.cpp` with `VSTControlOSX.mm`, but this needs some
conditional on WXMAC as well.
Conditionals are easy with CMake too.
A related, future problem which could be taken into account: wxQt is being
rebooted and starting to get somewhere, esp. on MS Windows from what I can
see. It definitely has the advantage of hiding a lot more platform-specific
issues. At the moment Audacity doesn't support this wx variant at all but
it would probably be a good idea to keep its existence in mind when
overhauling code that juggles different wx variants (and the build system).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#387?email_source=notifications&email_token=ACZBGYPEJLPSGJZBCPAB3FTQS7GDTA5CNFSM4JLKCSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUYZ5A#issuecomment-552176884>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZBGYNRYLFBTFXUO65R5HDQS7GDTANCNFSM4JLKCSSQ>
.
from audacity.
RJVB
commented on May 18, 2024
On Sunday November 10 2019 03:14:38 Paul Licameli wrote:
.mm files not included in the Windows and Linux builds. It would be a
pleasing separation.
The way we'd do that in KDE is by copying (instead of renaming) the required .cpp files to .mm, strip the ObjC code from the old .cpp files, and rewrite the build formula to include the .mm files on Mac instead of the .cpp files. Mostly trivial with CMake ....
from audacity.
Paul-Licameli
commented on May 18, 2024
On Sun, Nov 10, 2019 at 7:19 AM René Bertin <[email protected]>
wrote:
On Sunday November 10 2019 03:14:38 Paul Licameli wrote:
>.mm files not included in the Windows and Linux builds. It would be a
>pleasing separation.
The way we'd do that in KDE is by copying (instead of renaming) the
required .cpp files to .mm, strip the ObjC code from the old .cpp files,
and rewrite the build formula to include the .mm files on Mac instead of
the .cpp files. Mostly trivial with CMake ....
I hope that does not mean duplication of the C++ needed in both builds. Do
you mean the .mm file could #include the common code remaining in the .cpp
file?
PRL
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#387?email_source=notifications&email_token=ACZBGYJJI3Z3K4LZAK3LXETQS7353A5CNFSM4JLKCSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDU35FA#issuecomment-552189588>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZBGYPNQPHXPU4VXSOMMX3QS7353ANCNFSM4JLKCSSQ>
.
from audacity.
RJVB
commented on May 18, 2024
I hope that does not mean duplication of the C++ needed in both builds. Do
you mean the .mm file could #include the common code remaining in the .cpp
file?
Yes. You can of course also put only the ObjC++ code in .mm files which you pull in in addition to the .cpp files. Maybe a bit more work initially but indeed easier to maintain afterwards if only a small proportion is ObjC++ code .
from audacity.
eszlari
commented on May 18, 2024
cmake 3.16 will have support for Objective C/C++:
https://cmake.org/cmake/help/v3.16/release/3.16.html
from audacity.
mojca
commented on May 18, 2024
I know, but that doesn't help in any way at the moment. If files have wrong extension and you don't provide any explicit hints to it, CMake will also not magically recognise the need for objective C. Most importantly though the CMake build system is not yet ready.
from audacity.
RJVB
commented on May 18, 2024
cmake 3.16 will have support for Objective C/C++:
https://cmake.org/cmake/help/v3.16/release/3.16.html
> CMake learned to support the Objective C (OBJC) and Objective C++ (OBJCXX)
> languages. They may be enabled via the project() and enable_language()
> commands. When OBJC or OBJCXX is enabled, source files with the .m or .mm,
> respectively, will be compiled as Objective C or C++. Otherwise they will
> be treated as plain C++ sources as they were before.
I've been using ObjC/ObjC++ with cmake for quite a while now, I wasn't aware this didn't work?! Or maybe it just worked because at the very least clang looks at the file extension (I cannot recall having tried to build ObjC++ enabled projects with GCC).
from audacity.
JamesCrook
commented on May 18, 2024
CMake is now used to build Audacity, so this issue closed. Thanks to all who contributed to it.
from audacity.
Related Issues (20)
- Crash when move parts audio to another track HOT 4
- 3.5.1: local help pages are not visible via the menu HOT 1
- Export to original file location HOT 1
- Internal error when running macro that uses generator HOT 1
- Unable to build with GCC 14. HOT 2
- Missing header in WaveClip.cpp
- After changing the order of the effects in the stack, navigating between effects using the keyboard is in the wrong order
- Audacity fails to parse “~” tilde for user’s home directory in export audio dialog HOT 4
- Malformed waveform display HOT 2
- Plugin Manager: Unable to toggle state of multiple selected plug-ins HOT 6
- Too Many Options for Saving HOT 2
- "Silence Audio" command silently fails HOT 4
- Waveform not updated correctly on pasting into a clip. HOT 4
- Impossible to copy selected audio without copying the entire clip HOT 4
- Envelope points disappear unexpectedly
- Unable to import song at correct tempo if wrong tempo detected HOT 11
- MIDI playback ignores Note Track offset HOT 1
- Incorrect font scaling in track's control panel HOT 5
- Audacity crash upon installing Nyquist Plugins HOT 5
- Redundant "Enable" in View menu
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from audacity.