Comments (4)
This issue is the poster child for why ksh93 should use the equivalent OS provided functionality rather than that of the AST libraries. There will never be enough people who care about AST locale and timezone functions to fix bugs like this in a timely manner. If we want ksh93 to remain relevant we must update it to rely more on the functionality provided by the OS. Possibly providing fallback implementations when necessary but with the understanding that those fallback functions will always be best effort and likely to have shortcomings. Basic features like support for timezones and locales should not be the responsibility of this project.
from ast.
This is a reminder that we need to remove the ksh dependency on the AST time code. We've managed to remove the dependency on the AST vmalloc and AST locale subsystems (not 100% in the latter case but close enough). I recently removed a couple of AST time functions that were unused. It should be possible to replace the ksh dependency on the AST tm code with standard functions like timelocal()
instead of the AST tmlocal()
. And localtime()
instead of tmlocaltime()
. Etcetera.
There are several Coverity Scan issues involving the AST time subsystem. Rather than fix those problems it would be preferable to just remove the problematic code.
from ast.
Who knows about the TM_OPTIONS
env var? From src/lib/libast/tm/tminit.c:
stropt(getenv("TM_OPTIONS"), options, sizeof(*options), tmopt, NULL);
I'm betting there is no one outside the community of people which has examined the ksh source.
from ast.
Note that src/lib/libast/man/tm.3 does, sort of, document TM_OPTIONS
. But I'm willing to bet real money that 99.999999% of ksh users are wholly unaware of this env var. And I say "sort of" documented because that man page does not actually document its valid values. It only hints at the behavior that can be altered by setting that env var.
from ast.
Related Issues (20)
- Ctrl-B and Ctrl-F produces unexpected results in Emacs mode HOT 5
- Function scoped variable should retain its last value in while-loop body HOT 3
- printf %q broken with size specifier HOT 7
- 2020.0.0: test suite is failing HOT 8
- ksh: command substitution doesn't include the output of non-waited-for child processes HOT 1
- write package as an rpm (/bin/pacakge make) HOT 6
- Please fix invalid use of memccpy() on master HOT 5
- MacOS compiling libast
- ${$} throwing syntax error when use in cat << EOF on ksh93 93u+ . HOT 1
- Use of >/dev/null 2>&1 in called function causes "Abort(coredump)" HOT 4
- The subshell does not recognize the path path.
- Process substitution includes extraneous spaces in file descriptor HOT 1
- `a=()` should make `a` an empty array but doesn't HOT 2
- $EDITOR
- man page uses incorrect pipe character, "⎪" xE28EAA instead of "|" x7C HOT 1
- Please consider relicensing AST under the EPL-2.0 with the GPL compatibility clause
- ksh93u+ dumps core when fds >32 HOT 1
- building with Cygwin instead of NMAKE HOT 2
- The release page for the latest version of ksh boggles HOT 1
- undefined reference to `__dso_handle' HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ast.