Giter Club home page Giter Club logo

Comments (16)

jwdinius avatar jwdinius commented on May 9, 2024 3

I'll have a crack at this in the next couple of weeks. I have implemented in the past so it shouldn't be too difficult. Do you still want this @AtsushiSakai?

from pythonrobotics.

zhengzh avatar zhengzh commented on May 9, 2024 1

@jwdinius , Hi. As we know, in BFS algorithm, we should put every children of a parent node into the queue. He only puts the minimum cost node into the queue (in line), but forgets to put other nodes into the queue. I test the program with the MAZE (not the EMPTY_MAZE) and it gives 60 steps to reach the goal, but in this repo, it uses A* algorithm (not hybrid A*) and only needs 38 steps to reach the goal, and we know both algorithms should give the same optimal path. I don't know why the file is named as hybrid_breadth_first.cpp, I think BFS won't help decrease expanded nodes. The best and simplest hybrid A* implementation I have found is in this repo https://github.com/AtsushiSakai/HybridAStarTrailer, which is the just the same as the original paper described, although I never learn julia language before, I can still understand the code 😸.

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024 1

Ok @zhengzh , your points are well-taken. I have looked at the implementation and I will work to translate it to python 3.6. Do we want a more general hybrid a* implementation (like the A* implementation)? I will do the translation so that the core search algorithm can be easily imported into possible future hybrid a* implementations.

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@jwdinius Hi. Thank you for your suggestion. Yes. I still want it!!. Your PR is welcome.

from pythonrobotics.

xinbada007 avatar xinbada007 commented on May 9, 2024

Hey What's the progress now? Anyone adding the Hybrid-A* simulation?

Just wondering if it just misses the simulation implementation but the algorithm is complete?

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@xinbada007 I'm waiting a someone's PR.

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024

I have been unable to complete this work yet. I will try to have a PR by Christmas @xinbada007 @AtsushiSakai

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@jwdinius Thank you. Take your time : ) .

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024

I haven't forgotten about this. I missed the Christmas timeline, but I will be working on it this weekend @AtsushiSakai @xinbada007

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@jwdinius Thank you for your comment. Take your time and enjoy the end of the year.

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@jwdinius Hi. Are you working this issue?

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024

I'm sorry @AtsushiSakai, I've been unable to find the time to finish this. If anyone has the time before I can finish, here's a repo I am translating to python https://github.com/informramiz/Hybrid-Astar-search-algorithm.git. I will continue working on it, but I have no estimated time of completion.

from pythonrobotics.

zhengzh avatar zhengzh commented on May 9, 2024

BFS algorithm in Informaramiz's repo is wrong actually.

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024

@zhengzh thanks for the response. The implementation generates reasonable looking paths. What specifically is wrong with the implementation? If you know of something else to use as a starting point, I would be interested to hear about it.

from pythonrobotics.

jwdinius avatar jwdinius commented on May 9, 2024

#180 addresses this, so I'm stopping work

from pythonrobotics.

AtsushiSakai avatar AtsushiSakai commented on May 9, 2024

@jwdinius @zhengzh I merged #180 . Thank you so much for your help!!

from pythonrobotics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.