Giter Club home page Giter Club logo

Comments (6)

atomflunder avatar atomflunder commented on August 17, 2024

Hi, thanks again for the request!

I have been looking into multi-team rating for a bit for the TrueSkill algorithm, but since that is quite complex I have only a non-functioning prototype that I have always put off fixing. I think it should be easier for the Weng-Lin algorithm. If you want to go ahead, it would be much appreciated of course!

As for the API, it will not be compatible with the Outcomes enum. I would be fine with either a new enum or just type called something like MultiTeamOutcome or FFAOutcome or whatever sounds the best, and having a rank as usize inside it indicating team placements. Or just passing in the rating groups together with a usize indicating the rank directly into the rating function (Like the argument would be rating_groups: &[(&[WengLinRating], usize)]). But I am also open for something else if you have a better suggestion.

from skillratings.

asyncth avatar asyncth commented on August 17, 2024

Back to this profile.

Is MultiTeamOutcome supposed to be passed into a function in a tuple, just like usize example?

from skillratings.

atomflunder avatar atomflunder commented on August 17, 2024

Is MultiTeamOutcome supposed to be passed into a function in a tuple, just like usize example?

I could see having either either rating_groups: &[(&[WengLinRating], MultiTeamOutcome)], or rating_groups: &[&[WengLinRating]], outcomes: &[MultiTeamOutcome] working fine, what do you think?

from skillratings.

asyncth avatar asyncth commented on August 17, 2024

I like former one more I guess.

from skillratings.

asyncth avatar asyncth commented on August 17, 2024

What should be the name of this new function? Or should the original team function be modified instead?

from skillratings.

atomflunder avatar atomflunder commented on August 17, 2024

What should be the name of this new function? Or should the original team function be modified instead?

I like having a Team vs Team function as a shortcut, with more efficient calculations, so I personally would say we re-name the original function weng_ling_two_teams (or similar) and name the new function weng_lin_multi_team. I think the naming might be confusing to users otherwise. But, as always, I am open to better suggestions.

from skillratings.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.