Ability to remove event listener from event bus about bt HOT 4 OPEN

Or i guess it could be even better if event bus has client-specific scope i.e each client has its own event bus and listeners. So once client is done, so all the client-related things will be collected by GC. In this case we don't really need to have a way to remove listeners. We can silence them if it's required until the client is done.

from bt.

I'd prefer to stick with one event bus per runtime, but this is definitely a (minor) memory leak, so it would make sense to remove torrent-specific listeners, once the torrent is done or cancelled (i.e. the corresponding BtClient has terminated). The best place to do this should be somewhere in the processing chain (see bt.processor.TorrentProcessorFactory)

from bt.

but this is definitely a (minor) memory leak

Each successful handshake adds two listeners. This can be a serious memory leak. Especially when remote peer is malignant and creates incoming connections in loop.

from bt.

I guess it's around 30 bytes per connection, does not seem so critical. But again, I agree that this needs to be addressed.

from bt.