Giter Club home page Giter Club logo

Comments (7)

jasonrudolph avatar jasonrudolph commented on August 22, 2024

Ensure that the real-time client handles redirects, so that we have the freedom to update https://atom-tachyon.herokuapp.com to redirect to a different domain at any point in the future

With our current code, redirects alone could meet our needs. We'd need to update the server to redirect with a 301 status code for HEAD and GET requests, and a 307 status code for all other request verbs (e.g., POST). If we follow that approach, Electron will automatically follow the redirects. 👌


Note: We can't simply use a 301 redirect for all requests. When Electron (and other common HTTP clients) receive a 301 redirect, they use a GET request to follow the redirect. That's fine if the original request was a GET, but it's problematic if the original request was a POST, PATCH, DELETE, etc. In response to a 307, Electron uses the originally-specified HTTP verb to follow the redirect. 😅

FWIW, this is the same approach we used to implement redirects for renamed repositories in the GitHub API. https://github.com/github/github/pull/38672#issuecomment-75312884 😀

from teletype.

nathansobo avatar nathansobo commented on August 22, 2024

Okay, good to know. It might be nice to get a URL without herokuapp.com in it prior to release though so maybe let's leave this open.

from teletype.

jasonrudolph avatar jasonrudolph commented on August 22, 2024

It might be nice to get a URL without herokuapp.com in it prior to release though...

Totally. We can set up an atom.io subdomain easily. Agreeing on a github.com subdomain would likely require more discussion.

I'll toss up a few options to kickstart the discussion:

  • api.realtime.atom.io
  • api.real-time.atom.io
  • tachyon.atom.io
  • real-time-api.atom.io

Are any of those particularly appealing? Do any other ideas come to mind?

from teletype.

as-cii avatar as-cii commented on August 22, 2024

How about realtime-api.atom.io? I don't dig the 4th-level subdomain variant, and tachyon feels somewhat obscure (and asymmetric compared to our potential mini-site URL, realtime.atom.io).

from teletype.

jasonrudolph avatar jasonrudolph commented on August 22, 2024

@as-cii: Can we talk you into api.tachyon.atom.io?

/cc @nathansobo
/cc https://github.slack.com/archives/C65B6TS0K/p1506461529000042

from teletype.

as-cii avatar as-cii commented on August 22, 2024

I was assuming we wanted to stick with real-time, but as long as we re-brand the entire ecosystem as tachyon I am cool with api.tachyon.atom.io. 👍

from teletype.

jasonrudolph avatar jasonrudolph commented on August 22, 2024

I've updated https://github.com/github/dns/pull/752 to use api.tachyon.atom.io.

from teletype.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.