Ctrl-w doesn't close the console about atom-script HOT 6 CLOSED

What appears in your keybindings listing under settings?

from atom-script.

from atom-script.

I ended up customizing it including in keymap.cson

 '.platform-win32 .go-to-line .mini.editor input body .editor':
     'ctrl-w': 'script:close-view'

and it is working now.

any thoughts on why core:cancel was taking precedence?

from atom-script.

I am a little surprised that .platform-win32 is even being applied on your system. This is a Mac right?

It makes me think that vim mode is causing weird interactions, even though overriding core:cancel seemed to fix it.

By the way, I'm not really beholden to ctrl-w. Do you have any other suggestions? Back when atom-script was using a ScrollView, it worked with the default cmd-w/core:close.

from atom-script.

it is a Mac.
I will take a look if the vim mode is responsible for this weirdness.

Using a ScrollView and being able to use the default cmd-w/core:close sounds good to me.
any reasons to have moved to ctrl-w?

I'm just wondering that with so many atom packages having something different than the default may start conflicting a lot with other packages.

from atom-script.

Using a ScrollView and being able to use the default cmd-w/core:close sounds good to me.
any reasons to have moved to ctrl-w?

When we used the side pane, we realized some pain experienced by having it embedded the same way EditorViews are (#22).

I think we could get core:close to work on the display if we hook things up right. At the moment, it just closes the editor tab, regardless of whether you're focused on the script view or your code.

from atom-script.