The implementation of SockJS protocol is not right about atmosphere-extensions HOT 7 CLOSED

@jccampanero i don't know why the wrong index was used before.
we can apply your patch for the index part, but for the param method should be better replaced with something like
String[] params(String url, int pos) to return the params up to the pos-th position at once so that we don't need to call param(..., 2) and param(.., 3) and run the split twice. Here, I think, it is also simpler to iterate over indexOf('/') to pick the first pos params.

from atmosphere-extensions.

@elakito Sorry for the long time in reply.

I have pushed a new version of the code with the changes you indicated to me.

In this code you can see that I raise different validation, non expected, exceptions : please , I'd appreciate if you could verify that it does not break the logic followed by the rest of interceptors.

Feel free to ask me for any suggestions or improvements if appropiate.

from atmosphere-extensions.

@jccampanero somehow the diff is showing the entire file to be different from its parent and there are two such commits in this PR. That makes it difficult to see what has changed. If you could create a single commit file that only includes the relevant diff, that would be appreciated.
thanks.
regards, aki

from atmosphere-extensions.

@elakito you are right, I'm sorry, I did my changes in a windows system and it changed line endings.
I have rewrited our commit history: please, can you verify if the pull request is right now?
Thank you very much.
Regards,
J. Carlos

from atmosphere-extensions.

@jccampanero thanks.
I have merged your PR with a slight change.
regards, aki

from atmosphere-extensions.

@elakito Please, excuse my delay in reply.

Thank you very much for merge our changes in your library.

Thank you very much for your job and for your great library Aki.

Kind regards,
J. Carlos

from atmosphere-extensions.

@jccampanero atmosphere is a community supported project and we thank you for your valuable contribution ;-)
regards, aki

from atmosphere-extensions.